From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26DA9C282C8 for ; Mon, 28 Jan 2019 04:51:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D49152148E for ; Mon, 28 Jan 2019 04:51:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cl8EdIBT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbfA1Evm (ORCPT ); Sun, 27 Jan 2019 23:51:42 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:43716 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726607AbfA1Evm (ORCPT ); Sun, 27 Jan 2019 23:51:42 -0500 Received: by mail-ot1-f66.google.com with SMTP id a11so13556917otr.10 for ; Sun, 27 Jan 2019 20:51:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bR08rzA7EA7sJsJgXK9I/eXr2roF79WHvtrbxmvWV/A=; b=cl8EdIBTzLhhJsFrCheyz5QNufgmACGXKTnxqMUG0LBvuqKTXSI9XncypCfV4j5nXG wxSczAkzU5kBA05W1vqZdPOsLo+EvZfgDEnLPcYcSJsXz/q7wbjz7VQAbEpWJ2cFc79I +KW+pFW8wGKtm4DqC8pF4sXbrHN2IaVLq2OFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bR08rzA7EA7sJsJgXK9I/eXr2roF79WHvtrbxmvWV/A=; b=FXmQSQE3pxypQBgugA7Je+By0lj0RYgbjSQhpH3lE+Lo1qvIaSss7m0taSK/1aNGQc QqUx0kGCGCM+w+riXgiXuY5ZmRx4VcshCjgwZrgxATtN+TSyQYwgzsSiIN6qAs2UVw4z xje2tCFzPJwH0le04IrHxn/iNoWtPuUiWpEIt8pxxTrjE82AlimCH1wkOU8d6NubBxr3 qQy2ZiXgDH30BWU2UywIbXdDl6v8qeNZdFnikVLPhndVz+V+hG6fCixS2FPxpeAfigsH 9+DahfRjP+BFb5JxkSnk3tbx3wBdU5dc3RWVCCJgL7d+As3bkcJ53R0J84J/f5eVLkYk YDMw== X-Gm-Message-State: AJcUukdq+i9LsH0WDBqOiefNt7PatecDfhR+bTJ7oUL63BmDObff41AP gTcL289SWAoJbA9KzDEm0ZnJ0yatoC8= X-Google-Smtp-Source: ALg8bN7ekgOLwG9CgH6BGgxsA3q8l9XZlELqfhoM7TxHJ5U0FuUoMlbdhqXHS7T7pL9f6Mt0fGRalQ== X-Received: by 2002:a9d:1c97:: with SMTP id l23mr15901898ota.276.1548649844964; Sun, 27 Jan 2019 20:30:44 -0800 (PST) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com. [209.85.210.42]) by smtp.gmail.com with ESMTPSA id l6sm4254421otk.51.2019.01.27.20.30.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Jan 2019 20:30:44 -0800 (PST) Received: by mail-ot1-f42.google.com with SMTP id n8so13564882otl.6 for ; Sun, 27 Jan 2019 20:30:43 -0800 (PST) X-Received: by 2002:a9d:1b67:: with SMTP id l94mr14351362otl.147.1548649843040; Sun, 27 Jan 2019 20:30:43 -0800 (PST) MIME-Version: 1.0 References: <20190117162008.25217-1-stanimir.varbanov@linaro.org> <10deb3d1-2b10-43fe-bc77-4465f561c90a@linaro.org> <80b97fd8-bd3a-df74-c611-5da11bd7adc6@linaro.org> In-Reply-To: From: Tomasz Figa Date: Mon, 28 Jan 2019 13:30:32 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/10] Venus stateful Codec API To: Alexandre Courbot Cc: Stanimir Varbanov , Linux Media Mailing List , Mauro Carvalho Chehab , Hans Verkuil , LKML , linux-arm-msm , Vikash Garodia , Malathi Gottam Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 28, 2019 at 1:16 PM Alexandre Courbot wrote: > > On Fri, Jan 25, 2019 at 7:35 PM Stanimir Varbanov > wrote: > > > > Hi Alex, > > > > On 1/25/19 7:34 AM, Alexandre Courbot wrote: > > > On Thu, Jan 24, 2019 at 7:13 PM Stanimir Varbanov > > > wrote: > > >> > > >> Hi Alex, > > >> > > >> Thank you for review and valuable comments! > > >> > > >> On 1/24/19 10:43 AM, Alexandre Courbot wrote: > > >>> Hi Stanimir, > > >>> > > >>> On Fri, Jan 18, 2019 at 1:20 AM Stanimir Varbanov > > >>> wrote: > > >>>> > > >>>> Hello, > > >>>> > > >>>> This aims to make Venus decoder compliant with stateful Codec API [1]. > > >>>> The patches 1-9 are preparation for the cherry on the cake patch 10 > > >>>> which implements the decoder state machine similar to the one in the > > >>>> stateful codec API documentation. > > >>> > > >>> Thanks *a lot* for this series! I am still stress-testing it against > > >>> the Chromium decoder tests, but so far it has been rock-solid. I have > > >>> a few inline comments on some patches ; I will also want to review the > > >>> state machine more thoroughly after refreshing my mind on Tomasz doc, > > >>> but this looks pretty promising already. > > >> > > >> I'm expecting problems with ResetAfterFirstConfigInfo. I don't know why > > >> but this test case is very dirty. I'd appreciate any help to decipher > > >> what is the sequence of v4l2 calls made by this unittest case. > > > > > > I did not see any issue with ResetAfterFirstConfigInfo, however > > > ResourceExhaustion seems to hang once in a while. But I could already > > > see this behavior with the older patchset. > > > > Is it hangs badly? > > It just stops processing, no crash. I need to investigate more closely. > > > > > > > In any case I plan to thoroughly review the state machine. I agree it > > > is a bit complex to grasp. > > > > yes the state machine isn't simple and I blamed Tomasz many times for > > that :) Don't shoot the messenger! I'm just carrying what hardware and userspace made for us. ;) > > If I feel inspired I may try to extract the useful part of your patch > into a framework that we can use everywhere. :) We don't want every > driver to reimplement this complex state machine and introduce new > bugs every time. Yeah, we definitely need such a framework, especially given how the m2m framework is overused for handling codecs. Best regards, Tomasz