From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Alex Deucher <alexander.deucher@amd.com>,
Mike Rapoport <rppt@kernel.org>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails
Date: Thu, 17 Dec 2020 00:07:45 +0800 [thread overview]
Message-ID: <CAAd53p6Ef2zFX_t3y1c6O7BmHnxYGtGSfgzXAMQSom1ainWXzg@mail.gmail.com> (raw)
In-Reply-To: <s5hzh2dn3oa.wl-tiwai@suse.de>
On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Wed, 16 Dec 2020 16:50:20 +0100,
> Kai-Heng Feng wrote:
> >
> > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai <tiwai@suse.de> wrote:
> > >
> > > On Wed, 16 Dec 2020 13:47:24 +0100,
> > > Kai-Heng Feng wrote:
> > > >
> > > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller
> > > > initialization even if no codecs found"), when codec probe fails, it
> > > > doesn't enable runtime suspend, and can prevent graphics card from
> > > > getting powered down:
> > > > [ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized
> > > >
> > > > $ cat /sys/bus/pci/devices/0000:01:00.1/power/runtime_status
> > > > active
> > > >
> > > > So mark there's no codec and continue probing to let runtime PM to work.
> > > >
> > > > BugLink: https://bugs.launchpad.net/bugs/1907212
> > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> > >
> > > Hm, but if the probe fails, doesn't it mean something really wrong?
> > > IOW, how does this situation happen?
> >
> > The HDA controller is forcely created by quirk_nvidia_hda(). So
> > probably there's really not an HDA controller.
>
> I still don't understand how non-zero codec_mask is passed.
> The non-zero codec_mask means that BIOS or whatever believes that
> HD-audio codecs are present and let HD-audio controller reporting the
> presence. What error did you get at probing?
[ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized
Full dmesg here:
https://launchpadlibrarian.net/510351476/dmesg.log
>
>
> > > The usual no-codec state is for the devices that have a bogus HD-audio
> > > bus remaining while codecs aren't hooked or disabled by BIOS. For
> > > that, it makes to leave the controller driver and let it idle. But if
> > > you get really an error, it's something to fix there, not to just
> > > ignore in general.
> >
> > The best approach I can think of is to make current two steps probe
> > into one. So when probe fails, the driver won't bind to the device.
> > What's the reason behind the two steps approach?
>
> It's a sort of must, as the module loading is involved with binding
> with the codecs, as well as (optionally) request_firmware()
> invocation.
Ok. I also tried to use device_release_driver(), but azx_remove()
calls "cancel_work_sync(&hda->probe_work)" so there will be a
deadlock.
Kai-Heng
>
>
> Takashi
--
Kai-Heng
next prev parent reply other threads:[~2020-12-16 16:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 6:06 [PATCH] ALSA: hda: Enable runtime PM when codec probe fails Kai-Heng Feng
2020-12-14 7:58 ` Takashi Iwai
2020-12-16 12:47 ` [PATCH v2] ALSA: hda: Continue to probe " Kai-Heng Feng
2020-12-16 15:41 ` Takashi Iwai
2020-12-16 15:50 ` Kai-Heng Feng
2020-12-16 15:58 ` Takashi Iwai
2020-12-16 16:07 ` Kai-Heng Feng [this message]
2020-12-16 16:22 ` Takashi Iwai
2020-12-16 16:57 ` Takashi Iwai
2020-12-18 5:09 ` Kai-Heng Feng
2020-12-18 8:06 ` Takashi Iwai
2020-12-21 16:33 ` Kai-Heng Feng
2020-12-21 16:47 ` Takashi Iwai
2020-12-21 17:15 ` Kai-Heng Feng
2020-12-21 17:56 ` [Nouveau] " Ilia Mirkin
2020-12-22 2:49 ` Kai-Heng Feng
2021-01-04 13:20 ` Karol Herbst
2021-04-10 15:51 ` Roy Spliet
2021-04-10 19:23 ` Lukas Wunner
2021-04-10 20:48 ` Roy Spliet
2021-04-12 19:06 ` Aaron Plattner
2021-04-12 19:36 ` Roy Spliet
2021-04-12 20:00 ` Aaron Plattner
2021-04-12 20:03 ` Ilia Mirkin
2021-04-13 0:10 ` Karol Herbst
2021-04-13 8:24 ` Roy Spliet
2021-04-13 9:48 ` Karol Herbst
2021-04-13 11:17 ` Roy Spliet
2021-04-13 11:49 ` Karol Herbst
2021-06-25 12:45 ` Paul Cercueil
2021-07-02 17:59 ` Paul Cercueil
2021-07-02 18:26 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAd53p6Ef2zFX_t3y1c6O7BmHnxYGtGSfgzXAMQSom1ainWXzg@mail.gmail.com \
--to=kai.heng.feng@canonical.com \
--cc=alexander.deucher@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rppt@kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).