linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	linux-block@vger.kernel.org,
	Mike Galbraith <umgwanakikbuti@gmail.com>,
	minchan@kernel.org, ngupta@vflare.org,
	sergey.senozhatsky.work@gmail.com, bigeasy@linutronix.de
Subject: Re: swapon/913 is trying to acquire lock at zcomp_stream_get+0x5/0x90 [zram] but task is already holding lock at zs_map_object+0x7a/0x2e0
Date: Fri, 16 Oct 2020 19:00:29 +0500	[thread overview]
Message-ID: <CABXGCsOoY+J4kfX22c=KhGui_f=M4t72xXEEkUPM3szOd0WG+A@mail.gmail.com> (raw)
In-Reply-To: <20201016124009.GQ2611@hirez.programming.kicks-ass.net>

On Fri, 16 Oct 2020 at 17:40, Peter Zijlstra <peterz@infradead.org> wrote:
>
>
> Joy... __zram_bvec_write() and __zram_bvec_read() take these locks in
> opposite order.
>
> Does something like the (_completely_) untested below cure things?

Excellent! This patch (_completely_) cured all other warnings which
were present in the log.
dmesg before patch: https://pastebin.com/tZY3npHG
dmesg after patch: https://pastebin.com/iD7ZL1mb

Thanks!

--
Best Regards,
Mike Gavrilov.

  reply	other threads:[~2020-10-16 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16  6:21 swapon/913 is trying to acquire lock at zcomp_stream_get+0x5/0x90 [zram] but task is already holding lock at zs_map_object+0x7a/0x2e0 Mikhail Gavrilov
2020-10-16 12:40 ` Peter Zijlstra
2020-10-16 14:00   ` Mikhail Gavrilov [this message]
2020-10-16 15:33   ` Minchan Kim
2020-10-19 10:13     ` [PATCH] zram: Fix __zram_bvec_{read,write}() locking order Peter Zijlstra
2020-10-19 14:08       ` Minchan Kim
2020-10-19 15:29       ` Sebastian Andrzej Siewior
2020-10-19 15:32       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABXGCsOoY+J4kfX22c=KhGui_f=M4t72xXEEkUPM3szOd0WG+A@mail.gmail.com' \
    --to=mikhail.v.gavrilov@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=peterz@infradead.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).