From: Fox Chen <foxhlchen@gmail.com>
To: Ian Kent <raven@themaw.net>
Cc: Tejun Heo <tj@kernel.org>, Greg KH <gregkh@linuxfoundation.org>,
akpm@linux-foundation.org, dhowells@redhat.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
miklos@szeredi.hu, ricklind@linux.vnet.ibm.com,
sfr@canb.auug.org.au, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2 0/6] kernfs: proposed locking and concurrency improvement
Date: Fri, 18 Dec 2020 16:01:14 +0800 [thread overview]
Message-ID: <CAC2o3DJhx+dJX-oMKSTNabWYyRB750VABib+OZ=7UX6rGJZD5g@mail.gmail.com> (raw)
In-Reply-To: <67a3012a6a215001c8be9344aee1c99897ff8b7e.camel@themaw.net>
On Fri, Dec 18, 2020 at 3:36 PM Ian Kent <raven@themaw.net> wrote:
>
> On Thu, 2020-12-17 at 10:14 -0500, Tejun Heo wrote:
> > Hello,
> >
> > On Thu, Dec 17, 2020 at 07:48:49PM +0800, Ian Kent wrote:
> > > > What could be done is to make the kernfs node attr_mutex
> > > > a pointer and dynamically allocate it but even that is too
> > > > costly a size addition to the kernfs node structure as
> > > > Tejun has said.
> > >
> > > I guess the question to ask is, is there really a need to
> > > call kernfs_refresh_inode() from functions that are usually
> > > reading/checking functions.
> > >
> > > Would it be sufficient to refresh the inode in the write/set
> > > operations in (if there's any) places where things like
> > > setattr_copy() is not already called?
> > >
> > > Perhaps GKH or Tejun could comment on this?
> >
> > My memory is a bit hazy but invalidations on reads is how sysfs
> > namespace is
> > implemented, so I don't think there's an easy around that. The only
> > thing I
> > can think of is embedding the lock into attrs and doing xchg dance
> > when
> > attaching it.
>
> Sounds like your saying it would be ok to add a lock to the
> attrs structure, am I correct?
>
> Assuming it is then, to keep things simple, use two locks.
>
> One global lock for the allocation and an attrs lock for all the
> attrs field updates including the kernfs_refresh_inode() update.
>
> The critical section for the global lock could be reduced and it
> changed to a spin lock.
>
> In __kernfs_iattrs() we would have something like:
>
> take the allocation lock
> do the allocated checks
> assign if existing attrs
> release the allocation lock
> return existing if found
> othewise
> release the allocation lock
>
> allocate and initialize attrs
>
> take the allocation lock
> check if someone beat us to it
> free and grab exiting attrs
> otherwise
> assign the new attrs
> release the allocation lock
> return attrs
>
> Add a spinlock to the attrs struct and use it everywhere for
> field updates.
>
> Am I on the right track or can you see problems with this?
>
> Ian
>
umm, we update the inode in kernfs_refresh_inode, right?? So I guess
the problem is how can we protect the inode when kernfs_refresh_inode
is called, not the attrs??
thanks,
fox
next prev parent reply other threads:[~2020-12-18 8:02 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 7:37 [PATCH v2 0/6] kernfs: proposed locking and concurrency improvement Ian Kent
2020-06-17 7:37 ` [PATCH v2 1/6] kernfs: switch kernfs to use an rwsem Ian Kent
2020-06-17 7:37 ` [PATCH v2 2/6] kernfs: move revalidate to be near lookup Ian Kent
2020-06-17 7:37 ` [PATCH v2 3/6] kernfs: improve kernfs path resolution Ian Kent
2020-06-17 7:38 ` [PATCH v2 4/6] kernfs: use revision to identify directory node changes Ian Kent
2020-06-17 7:38 ` [PATCH v2 5/6] kernfs: refactor attr locking Ian Kent
2020-06-17 7:38 ` [PATCH v2 6/6] kernfs: make attr_mutex a local kernfs node lock Ian Kent
2020-06-19 15:38 ` [PATCH v2 0/6] kernfs: proposed locking and concurrency improvement Tejun Heo
2020-06-19 20:41 ` Rick Lindsley
2020-06-19 22:23 ` Tejun Heo
2020-06-20 2:44 ` Rick Lindsley
2020-06-22 17:53 ` Tejun Heo
2020-06-22 21:22 ` Rick Lindsley
2020-06-23 23:13 ` Tejun Heo
2020-06-24 9:04 ` Rick Lindsley
2020-06-24 9:27 ` Greg Kroah-Hartman
2020-06-24 13:19 ` Tejun Heo
2020-06-25 8:15 ` Ian Kent
2020-06-25 9:43 ` Greg Kroah-Hartman
2020-06-26 0:19 ` Ian Kent
2020-06-21 4:55 ` Ian Kent
2020-06-22 17:48 ` Tejun Heo
2020-06-22 18:03 ` Greg Kroah-Hartman
2020-06-22 21:27 ` Rick Lindsley
2020-06-23 5:21 ` Greg Kroah-Hartman
2020-06-23 5:09 ` Ian Kent
2020-06-23 6:02 ` Greg Kroah-Hartman
2020-06-23 8:01 ` Ian Kent
2020-06-23 8:29 ` Ian Kent
2020-06-23 11:49 ` Greg Kroah-Hartman
2020-06-23 9:33 ` Rick Lindsley
2020-06-23 11:45 ` Greg Kroah-Hartman
2020-06-23 22:55 ` Rick Lindsley
2020-06-23 11:51 ` Ian Kent
2020-06-21 3:21 ` Ian Kent
2020-12-10 16:44 ` Fox Chen
2020-12-11 2:01 ` [PATCH " Ian Kent
2020-12-11 2:17 ` Ian Kent
2020-12-13 3:46 ` Ian Kent
2020-12-14 6:14 ` Fox Chen
2020-12-14 13:30 ` Ian Kent
2020-12-15 8:33 ` Fox Chen
2020-12-15 12:59 ` Ian Kent
2020-12-17 4:46 ` Ian Kent
2020-12-17 8:54 ` Fox Chen
2020-12-17 10:09 ` Ian Kent
2020-12-17 11:09 ` Ian Kent
2020-12-17 11:48 ` Ian Kent
2020-12-17 15:14 ` Tejun Heo
2020-12-18 7:36 ` Ian Kent
2020-12-18 8:01 ` Fox Chen [this message]
2020-12-18 11:21 ` Ian Kent
2020-12-18 13:20 ` Fox Chen
2020-12-19 0:53 ` Ian Kent
2020-12-19 7:47 ` Fox Chen
2020-12-22 2:17 ` Ian Kent
2020-12-18 14:59 ` Tejun Heo
2020-12-19 7:08 ` Ian Kent
2020-12-19 16:23 ` Tejun Heo
2020-12-19 23:52 ` Ian Kent
2020-12-20 1:37 ` Ian Kent
2020-12-21 9:28 ` Fox Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC2o3DJhx+dJX-oMKSTNabWYyRB750VABib+OZ=7UX6rGJZD5g@mail.gmail.com' \
--to=foxhlchen@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=raven@themaw.net \
--cc=ricklind@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).