From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669F8C433E1 for ; Tue, 26 May 2020 18:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 454622086A for ; Tue, 26 May 2020 18:09:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="QV6eN1wz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729765AbgEZSJv (ORCPT ); Tue, 26 May 2020 14:09:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728838AbgEZSJv (ORCPT ); Tue, 26 May 2020 14:09:51 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 102C4C03E96E for ; Tue, 26 May 2020 11:09:51 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id nu7so126473pjb.0 for ; Tue, 26 May 2020 11:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SwJVwRsf4JLRcqoa9J+40Z33dh8YZfs8m9tFvpvW4ww=; b=QV6eN1wz/6AFupUQIoxfvaiVQr3VOLFnMyRTzupBK2x5UnbAlfVQHIl6yfVjKSnMu5 umzskbig4ieeQkFfLiBEUxyS/rwM3NDzxKtqi8fgYUz362ncGMXqwUf3DjNADPk94joc sQer+mGXxLQjq5r5/VevoRSQ49Ax1BoPA19/0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SwJVwRsf4JLRcqoa9J+40Z33dh8YZfs8m9tFvpvW4ww=; b=bFMOfc3YTWBrZrz+GK3Kyw3T5IkRDbnuk7zdplhZTw6r47qqkOkstduI66yvhl0vP9 9ZvT//1u8+CXj2fYzj4LDJqcbCPTEbsWf+Rgoyp8VvUsagaen2bmHrh4t7nyeoB3uWJU MeWOMqlbRwy282uPQxHMFwZf3u4KW7BsNoEYaMuU7KwmHSGGL2+KqU9AHj/ZM8tWZc8Q GxQG+dEAr1GrYBvCY8IQ2MwK0xoXtQILAz1E0zULAddbXUJHk4ihfpy9kh/yRFWpcFMU hqn3DpnHmYgzwLM+PHmQuzFec+6T6qkdlRv1x6rZghLQhkhtfitIgfkSiOvCwStVgv3X /itw== X-Gm-Message-State: AOAM532AQ+rYvyQP1KGQGyLH33L2OKGIj2jeMgPcde+vBeFeyNnVQKAh XqggKo+GGyn/6VtA6/59TObLwFWUf/89spR2gV1qjA== X-Google-Smtp-Source: ABdhPJw0zdtsZqR6XZR5M0EU2Em6fXtef9eG1yF+ia1DKSMmJ8d7PdM5no22jZaDVe0gm/zwiK1kl46oQKDlpGuKAiA= X-Received: by 2002:a17:902:e903:: with SMTP id k3mr2106595pld.317.1590516590375; Tue, 26 May 2020 11:09:50 -0700 (PDT) MIME-Version: 1.0 References: <20200526145815.6415-1-mcgrof@kernel.org> <20200526145815.6415-7-mcgrof@kernel.org> In-Reply-To: <20200526145815.6415-7-mcgrof@kernel.org> From: Michael Chan Date: Tue, 26 May 2020 11:09:38 -0700 Message-ID: Subject: Re: [PATCH v3 6/8] bnxt_en: use new taint_firmware_crashed() To: Luis Chamberlain Cc: jeyu@kernel.org, David Miller , Jakub Kicinski , dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, aelior@marvell.com, GR-everest-linux-l2@marvell.com, kvalo@codeaurora.org, johannes@sipsolutions.net, akpm@linux-foundation.org, Arnd Bergmann , rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, Baoquan He , peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, derosier@gmail.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, vkoul@kernel.org, mchehab+huawei@kernel.org, robh@kernel.org, mhiramat@kernel.org, sfr@canb.auug.org.au, linux@dominikbrodowski.net, glider@google.com, paulmck@kernel.org, elver@google.com, bauerman@linux.ibm.com, yamada.masahiro@socionext.com, samitolvanen@google.com, yzaikin@google.com, dvyukov@google.com, rdunlap@infradead.org, corbet@lwn.net, dianders@chromium.org, Netdev , open list , linux-doc@vger.kernel.org, Vasundhara Volam Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 7:58 AM Luis Chamberlain wrote: > > From: Vasundhara Volam > > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / reload and in the worst cases > a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: Michael Chan > Cc: Luis Chamberlain > Acked-by: Rafael Aquini > Signed-off-by: Vasundhara Volam > Signed-off-by: Luis Chamberlain Reviewed-by: Michael Chan