linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: javier Martin <javier.martin@vista-silicon.com>
To: "Gaëtan Carlier" <gcembed@gmail.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	broonie@opensource.wolfsonmicro.com, fabio.estevam@freescale.com,
	s.hauer@pengutronix.de
Subject: Re: [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support'.
Date: Tue, 4 Sep 2012 11:09:20 +0200	[thread overview]
Message-ID: <CACKLOr1nobfaKRnVVuiODAfCUugCYJ2=pDvbz6wn1Yexy7qb6A@mail.gmail.com> (raw)
In-Reply-To: <5045A11B.3070300@gmail.com>

On 4 September 2012 08:35, Gaëtan Carlier <gcembed@gmail.com> wrote:
> Hi Javier,
>
> On 09/03/2012 10:27 AM, Javier Martin wrote:
>>
>> The following commit should be reverted:
>> 0865a75d4166bddc533fd50831829ceefb94f9b0
>>
>> The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards.
>> Furthermore, after applying this patch sound in Visstrim_M10 is played
>> at slower rates.
>>
>> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
>> ---
>> diff --git b/sound/soc/fsl/imx-ssi.c a/sound/soc/fsl/imx-ssi.c
>> index ac337ac..28dd76c 100644
>> --- b/sound/soc/fsl/imx-ssi.c
>> +++ a/sound/soc/fsl/imx-ssi.c
>> @@ -380,13 +380,13 @@ static int imx_ssi_dai_probe(struct snd_soc_dai
>> *dai)
>>   static struct snd_soc_dai_driver imx_ssi_dai = {
>>         .probe = imx_ssi_dai_probe,
>>         .playback = {
>> -               .channels_min = 2,
>> +               .channels_min = 1,
>>                 .channels_max = 2,
>>                 .rates = SNDRV_PCM_RATE_8000_96000,
>>                 .formats = SNDRV_PCM_FMTBIT_S16_LE,
>>         },
>>         .capture = {
>> -               .channels_min = 2,
>> +               .channels_min = 1,
>>                 .channels_max = 2,
>>                 .rates = SNDRV_PCM_RATE_8000_96000,
>>                 .formats = SNDRV_PCM_FMTBIT_S16_LE,
>>
> When applied on linux-next-20120824, the patch failed because original
> imx-ssi.c file looks like :
>
> static struct snd_soc_dai_driver imx_ssi_dai = {
>         .probe = imx_ssi_dai_probe,
>         .playback = {
>                 /* The SSI does not support monaural audio. */
>
>                 .channels_min = 2,
>                 .channels_max = 2,
>                 .rates = SNDRV_PCM_RATE_8000_96000,
>                 .formats = SNDRV_PCM_FMTBIT_S16_LE,
>         },
>         .capture = {
>                 .channels_min = 2,
>                 .channels_max = 2,
>                 .rates = SNDRV_PCM_RATE_8000_96000,
>                 .formats = SNDRV_PCM_FMTBIT_S16_LE,
>         },
>         .ops = &imx_ssi_pcm_dai_ops,
> };
>
> The comment line is missing in your patch. Here is the right patch :
>
> @@ -378,18 +378,17 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai)
>
>  }
>
>  static struct snd_soc_dai_driver imx_ssi_dai = {
>         .probe = imx_ssi_dai_probe,
>         .playback = {
> -               /* The SSI does not support monaural audio. */
>
> -               .channels_min = 2,
> +               .channels_min = 1,
>                 .channels_max = 2,
>                 .rates = SNDRV_PCM_RATE_8000_96000,
>                 .formats = SNDRV_PCM_FMTBIT_S16_LE,
>         },
>         .capture = {
> -               .channels_min = 2,
> +               .channels_min = 1,
>                 .channels_max = 2,
>                 .rates = SNDRV_PCM_RATE_8000_96000,
>                 .formats = SNDRV_PCM_FMTBIT_S16_LE,
>         },
>         .ops = &imx_ssi_pcm_dai_ops,
>
> Regards,
> Gaëtan Carlier.


Mark,
could you pick up the fixed patch sent by Gaëtan?

Regards.

-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com

  reply	other threads:[~2012-09-04  9:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03  8:27 [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support' Javier Martin
2012-09-03 16:16 ` Fabio Estevam
2012-09-04  6:35 ` Gaëtan Carlier
2012-09-04  9:09   ` javier Martin [this message]
2012-09-06  0:19     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACKLOr1nobfaKRnVVuiODAfCUugCYJ2=pDvbz6wn1Yexy7qb6A@mail.gmail.com' \
    --to=javier.martin@vista-silicon.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=fabio.estevam@freescale.com \
    --cc=gcembed@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).