From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05514C432BE for ; Wed, 4 Aug 2021 22:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6C2E60F25 for ; Wed, 4 Aug 2021 22:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234972AbhHDWCP (ORCPT ); Wed, 4 Aug 2021 18:02:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52850 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhHDWCO (ORCPT ); Wed, 4 Aug 2021 18:02:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628114520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d2KqUld+afo/DqE9+AEtQTsC0qFJZ5g464VDzN5fDCk=; b=DznlWIsIohk04aVdpHuasVaWIpn8mGeEI3/N4ONXjaLG+NfnuxbGlM40phnf0Mko7D3CNP o7ll2jECSR28U4AqOrVcw24K42YjHxR2OoO9C4tVF+O+dcmP/oNt6jULlZaZpZGtDiileM Ea3FcVdOPwapWD7Lw9XhQIUSEFQi3xc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-ovtQRFh_MEaJwMBn1iEjNw-1; Wed, 04 Aug 2021 18:01:59 -0400 X-MC-Unique: ovtQRFh_MEaJwMBn1iEjNw-1 Received: by mail-wr1-f71.google.com with SMTP id d10-20020a056000114ab02901537f048363so1281199wrx.8 for ; Wed, 04 Aug 2021 15:01:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d2KqUld+afo/DqE9+AEtQTsC0qFJZ5g464VDzN5fDCk=; b=g5QlfTb67LmxSBkRgeFIfJzCBpBgConhS0EOJZaPEHNO1/wNxwLvpXAN1zeYG06x0t PRaSC4W0hoyw5EGv9mO3ilxCrPYmhsBQyuFOXYqrapFfx8rtbZASm/S5vppild7Qjjwd JMrswhedLVM+5bbgU1m831yVtPjAfr5HTCqQ92FXe3juh5pyrEiHuFr/kqIUREpMxXiy WdLCHlFTg09jE5bU4RkBbc6fC565RH5+NI7jFbxCHQkTSrxE4jqjsypoNCtc4BBSXEnH /5nBVpXvYIlHOS4a1ZXwFnVVs7kaSOTj8dW3gZpepOL2NlG+OY/P/qpT7pF+A2EuEk93 fm8A== X-Gm-Message-State: AOAM533aIGL670lkn1yVuElb8rxnFzGhvg3iaoyoGnPJ8GvYgBNNzWwK PhphVJRNtt0hha3GT2Ds88/RmbOvZYkYCeStIC2PkIUzzvTrcE57QrK2YR3e3HG65uhzcW5QbhU jO7zIdtP2XsgOOGdTHYpSUodODtBQ90nE69GxlnVY X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr11802093wmm.171.1628114518450; Wed, 04 Aug 2021 15:01:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY5/nXWklNR1mjmCS911U1388HsPu+p770sIXPA+rC70wi12iHVm9penxHkIrsLojhFxJ+H/cT1xS0GAj+5BQ= X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr11802083wmm.171.1628114518302; Wed, 04 Aug 2021 15:01:58 -0700 (PDT) MIME-Version: 1.0 References: <20210804141049.499767-1-kherbst@redhat.com> In-Reply-To: From: Karol Herbst Date: Thu, 5 Aug 2021 00:01:47 +0200 Message-ID: Subject: Re: [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices To: Arnd Bergmann Cc: Linux Kernel Mailing List , Lyude Paul , Ben Skeggs , Randy Dunlap , Daniel Vetter , ML nouveau , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > > > > > playing around a little bit with this, I think the original "select > > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > > > drivers selecting and others depending on it. We could of course convert > > > > > everything over to depend, and break those cycling dependency issues with > > > > > this. > > > > > > > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > > > > happy and has the advantage of not having to mess with the deps of nouveau > > > > > too much. > > > > > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > > keep working. > > > > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > > BACKLIGHT_CLASS_DEVICE might be disabled :( > > Are you sure? It should already be the case that any driver that selects > FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' > or 'select BACKLIGHT_CLASS_DEVICE'. > none of the fb drivers seem to do that. > If you change all the 'select BACKLIGHT_CLASS_DEVICE' to 'depends > on', I don't see a problem with doing 'select FB_BACKLIGHT' from > those. > > I have applied your patch to my randconfig tree and built a few dozen > kernels, don't see any regressions so far, but will let it run over night. > > Arnd >