From: Joel Stanley <joel@jms.id.au>
To: Tommy Haung <tommy_huang@aspeedtech.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [PATCH v5 0/7] Add Aspeed AST2600 soc display support
Date: Mon, 28 Feb 2022 09:53:06 +0000 [thread overview]
Message-ID: <CACPK8XcTDUt8q+5s44nnFFK1XiisXw=PBoGaNZowGS7M-j=Phg@mail.gmail.com> (raw)
In-Reply-To: <20211208013337.13806-1-tommy_huang@aspeedtech.com>
Hi Tommy,
On Wed, 8 Dec 2021 at 01:34, Tommy Haung <tommy_huang@aspeedtech.com> wrote:
>
> v5:
> Add lost reset define.
>
> v4:
> Add necessary reset control for ast2600.
> Add chip caps for futher use.
> These code are test on AST2500 and AST2600 by below steps.
>
> 1. Add below config to turn VT and LOGO on.
>
> CONFIG_TTY=y
> CONFIG_VT=y
> CONFIG_CONSOLE_TRANSLATIONS=y
> CONFIG_VT_CONSOLE=y
> CONFIG_VT_CONSOLE_SLEEP=y
> CONFIG_HW_CONSOLE=y
> CONFIG_VT_HW_CONSOLE_BINDING=y
> CONFIG_UNIX98_PTYS=y
> CONFIG_LDISC_AUTOLOAD=y
> CONFIG_DEVMEM=y
> CONFIG_DUMMY_CONSOLE=y
> CONFIG_FRAMEBUFFER_CONSOLE=y
> CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY=y
> CONFIG_LOGO=y
> CONFIG_LOGO_LINUX_CLUT224=y
>
> 2. The Linux logo will be shown on the screen, when the BMC boot in Linux.
Sorry for the long delay. I have tested your patches on an ast2600a3
evb and they worked. I have some questions about the reset lines that
I couldn't answer by reading the datasheet, so once they are cleared
up we can go ahead with merging your patches.
When you re-send, you will need to fix your git configuration so your
name appears correctly:
git config --global user.name "Tommy Haung"
And then for each patch, do this to fix up the authorship and the s-o-b line:
git commit --amend --reset-author -s
Cheers,
Joel
>
> v3:
> Refine the patch for clear separate purpose.
> Skip to send devicetree patch
>
> v2:
> Remove some unnecessary patch.
> Refine for reviwer request.
>
> v1:
> First add patch.
>
> Joel Stanley (2):
> ARM: dts: aspeed: Add GFX node to AST2600
> ARM: dts: aspeed: ast2600-evb: Enable GFX device
>
> Tommy Haung (1):
> dt-bindings:ast2600-clock Add CRT reset define
>
> tommy-huang (4):
> drm/aspeed: Update INTR_STS handling
> drm/aspeed: Add AST2600 chip support
> drm/aspeed: Add reset and clock for AST2600
> arm:boot:dts:aspeed-g6 Add more gfx reset control
>
> arch/arm/boot/dts/aspeed-ast2600-evb.dts | 18 +++++++
> arch/arm/boot/dts/aspeed-g6.dtsi | 13 +++++
> drivers/gpu/drm/aspeed/aspeed_gfx.h | 17 +++++-
> drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 16 ++++++
> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 65 +++++++++++++++++++++--
> include/dt-bindings/clock/ast2600-clock.h | 1 +
> 6 files changed, 124 insertions(+), 6 deletions(-)
>
> --
> 2.17.1
>
prev parent reply other threads:[~2022-02-28 9:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 1:33 [PATCH v5 0/7] Add Aspeed AST2600 soc display support Tommy Haung
2021-12-08 1:33 ` [PATCH v5 1/7] ARM: dts: aspeed: Add GFX node to AST2600 Tommy Haung
2021-12-08 1:33 ` [PATCH v5 2/7] ARM: dts: aspeed: ast2600-evb: Enable GFX device Tommy Haung
2021-12-08 1:33 ` [PATCH v5 3/7] drm/aspeed: Update INTR_STS handling Tommy Haung
2021-12-08 1:33 ` [PATCH v5 4/7] drm/aspeed: Add AST2600 chip support Tommy Haung
2022-02-28 9:44 ` Joel Stanley
2021-12-08 1:33 ` [PATCH v5 5/7] drm/aspeed: Add reset and clock for AST2600 Tommy Haung
2022-02-28 9:50 ` Joel Stanley
2022-03-01 7:00 ` Tommy Huang
2022-03-01 11:04 ` Joel Stanley
2022-03-02 0:04 ` Tommy Huang
2021-12-08 1:33 ` [PATCH v5 6/7] arm:boot:dts:aspeed-g6 Add more gfx reset control Tommy Haung
2021-12-08 1:33 ` [PATCH v5 7/7] dt-bindings:ast2600-clock Add CRT reset define Tommy Haung
2021-12-10 21:18 ` Rob Herring
2022-02-28 9:53 ` Joel Stanley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XcTDUt8q+5s44nnFFK1XiisXw=PBoGaNZowGS7M-j=Phg@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=BMC-SW@aspeedtech.com \
--cc=airlied@linux.ie \
--cc=andrew@aj.id.au \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tommy_huang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).