From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724BDC432BE for ; Wed, 11 Aug 2021 12:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 563BB61008 for ; Wed, 11 Aug 2021 12:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbhHKMl0 (ORCPT ); Wed, 11 Aug 2021 08:41:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbhHKMlZ (ORCPT ); Wed, 11 Aug 2021 08:41:25 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6D8EC061765 for ; Wed, 11 Aug 2021 05:41:01 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id c24so5347001lfi.11 for ; Wed, 11 Aug 2021 05:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sVEJCnI/+j28u/yya/sb9JoujCNOibmrs6FLKDvPdSM=; b=BJ6tQSXnTFlKSNIJGIoltg69Zs/3IcQRIpOvR0zQ+ET12mqlsONIm0ek1cOLASysVM 1167rK3gUfIn0u7xVBdGwXircRtuuqmcOaIqaUiqaKEJtKLBR3m6CBqmQznvPfLUkDzZ MhDO1L/9YmRMWMzps6OIfnJ3kifoHjRGZ3gqZojWsGSTsS7Bms+PCzIqc53mZoNdqEK7 UmGZsg6JEFCvczUuYAnABJHd/DxRxEQue5v9dDgH/L0xH5qj5frWXOHc88x09zrt4uWF eF83XhOcAvqQs+W2KDo/HvomIQHggkbtLKG75uZySrJT0Pvh6moYw/+wbg4IVKHaGS0W gAgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sVEJCnI/+j28u/yya/sb9JoujCNOibmrs6FLKDvPdSM=; b=RWkBeu74pr+3NlWEeJMBB6fnbhIsW7GgCVPKdpawSXcuBitJfsIFxWtF3FaGX/wBXJ C9fqge3fIWtZNYN0T64+/6G4BiDsh5dp2F9F1KQ5JDBNKa96hKWw5tUa8LYIYprkXzlW r304+At9xCpEZUxCa+H1oFFJOSQ3rlT+zi/CmIeLraXEHNAxRxPaDYVrC8LIfBwX/LDG KNstK9ow1UKwl98PmxT9elRDB/TYTjmEf68kJ1QRVjpzWrz0Pf8nJobLJ/7nyMqkw2bn 44MeJlBMBxmZ/+B4+xOM5u6Mz/ql8OS+VUuf/IwHulps0EkDQxts7Z2q6KVb3EsVbVgo qNDw== X-Gm-Message-State: AOAM530oH2ZRKNjaVHj63cP4Goio6nETvsuFfSnXWnRBKdJSB1mcVS3j ktwJPDXTdfFHRxsN5ZMPylo0XYoHB7l2BoaoSPff0g== X-Google-Smtp-Source: ABdhPJxSCJ+yI29pfgowRW50YlvCiE0YBbuZh0GpYHOyKZvQSwWzV7Ob4c6QrJa9RUbIVKVEX+ioY2X+Yn67VegXHf0= X-Received: by 2002:a19:c7cd:: with SMTP id x196mr25025885lff.465.1628685660264; Wed, 11 Aug 2021 05:41:00 -0700 (PDT) MIME-Version: 1.0 References: <20210726125436.58685-1-andriy.shevchenko@linux.intel.com> <20210726125436.58685-2-andriy.shevchenko@linux.intel.com> <20210802135839.4clqd34npppwasyh@mobilestation> <20210804124433.crh7w6jzfjcswubo@mobilestation> In-Reply-To: From: Linus Walleij Date: Wed, 11 Aug 2021 14:40:49 +0200 Message-ID: Subject: Re: [PATCH v1 2/4] gpio: dwapb: Read GPIO base from gpio-base property To: Andy Shevchenko Cc: Serge Semin , Rob Herring , Bartosz Golaszewski , Serge Semin , Lee Jones , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Hoan Tran Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 4, 2021 at 4:44 PM Andy Shevchenko wrote: > On Wed, Aug 04, 2021 at 03:44:33PM +0300, Serge Semin wrote: > > Thus, yes, I think we need to make sure here that the property > > is only used in framework of the kernel and isn't passed via > > inappropriate paths like DT/ACPI fw so not to get into the > > maintainability troubles in future. > > Got it. I'll add the additional check in next version. This seems reasonable for me, if you can get this done with some kind of elegance. Maybe use the "linux,gpio-base" property as mentioned so it is clear that this is a Linux-internal thing only. Yours, Linus Walleij