From: Linus Walleij <linus.walleij@linaro.org>
To: Thierry Reding <thierry.reding@avionic-design.de>,
Arun MURTHY <arun.murthy@stericsson.com>
Cc: Srinidhi KASAGAR <srinidhi.kasagar@stericsson.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
Date: Mon, 3 Sep 2012 13:51:58 +0200 [thread overview]
Message-ID: <CACRpkdZGu+GT+V7i+h3YrQDN930MYYprLS1kmgM1+rOaUaebdA@mail.gmail.com> (raw)
In-Reply-To: <F45880696056844FA6A73F415B568C695B0EA11A90@EXDCVYMBSTM006.EQ1STM.local>
On Mon, Sep 3, 2012 at 1:28 PM, Arun MURTHY <arun.murthy@stericsson.com> wrote:
>> On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding <thierry.reding@avionic-
>> design.de> wrote:
>>
>> > This commit moves the driver to drivers/pwm and converts it to the new
>> > PWM framework.
>> >
>> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
>> > ---
>> > Note: I'll take this through the PWM tree, but I'd like to have it
>> > acknowledged by a few people who know the hardware and can actually
>> > test whether this still works.
>>
>> Pls include Arun on these patches, he'll know best if it'll work or not.
>>
>> I have one generic question: will this alter the layout of sysfs so we need to
>> change userspace? I had such issues before when moving drivers to new
>> busses...
>>
>
> Since this pwm framework is still a set of exported functions in a header file,
> the file architecture doesn't really matter.
> Using this driver, either leds-pwm and backlight-pwm is used to register and
> this is where actual registration happens(sysfs entry is created).
OK sounds good to me,
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-09-03 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 10:30 [PATCH] pwm: Move AB8500 PWM driver to PWM framework Thierry Reding
2012-09-02 18:55 ` Arnd Bergmann
2012-09-02 19:09 ` Thierry Reding
2012-09-03 11:10 ` Linus Walleij
2012-09-03 11:28 ` Arun MURTHY
2012-09-03 11:51 ` Linus Walleij [this message]
2012-09-07 13:22 ` Thierry Reding
2012-09-13 15:25 ` Thierry Reding
2012-09-17 5:01 ` Arun MURTHY
2012-09-20 10:54 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZGu+GT+V7i+h3YrQDN930MYYprLS1kmgM1+rOaUaebdA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=arun.murthy@stericsson.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinidhi.kasagar@stericsson.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).