From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6D4C5DF61 for ; Thu, 7 Nov 2019 08:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE14B206DF for ; Thu, 7 Nov 2019 08:03:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lcxWbUY5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727556AbfKGIDI (ORCPT ); Thu, 7 Nov 2019 03:03:08 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:41635 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfKGIDI (ORCPT ); Thu, 7 Nov 2019 03:03:08 -0500 Received: by mail-lj1-f194.google.com with SMTP id m9so1151721ljh.8 for ; Thu, 07 Nov 2019 00:03:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kmm/jBUyOVxQYEej8YoVC+NyodK4z5S7O58CZiY/vk4=; b=lcxWbUY56TCq5OVhHvHP0fLd9Bnxpoto8fgVFrKDJpIxr3G9KHi3Pmy9oszlcNSXgo t0YI2eSOCjOw6F3uNrPqnjVh7GN0eObzxtVPJZ31uKAuEK4RSUr85mIiDCZShGmKUDoQ qTjbiNZTTyc8uZcFINlQ3Dx0xm0q4a4QMRb6gqBNz2VuiTME2L0TZn7aQ58d5uu1erAM 0xqVnN+znJy+EtBmwpxPP1CX03jiq0cpQZOvZqK9/405oBUdMUiFLMEAQiEPpw6NhHLS NDHWrFBkfMw0NM5OGZdXgM+UKFRCGLrT0xv8SgtAXkwa8q382pidcHyxyCZiyfIfv+jQ A8lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kmm/jBUyOVxQYEej8YoVC+NyodK4z5S7O58CZiY/vk4=; b=ubyRRwRher4E1s8DFd2MwRXRAbXe5fA7LJW0qWzBFn6sdxqgg388XH7pno6/f8f54D MW8NbmTFalos5ezuaEiieTs8Hk59EEFljoPGjckmFgHxapdOonJxK5oLJRPIMxB1UxJB Vpjd1CADsYuV2vQHeh0w726HrWSYNxA2fgWNU+TMDLIEyHsfThItyFjpeE8B9rfF42N5 6r6t16RXYJIPRJfX2KlTRv8FO9kG/nZemOB5rRMpKGjWGArIyx61h2cYySVSZ3LZRY8m L+5671BhaYW2xOA0z58Ny8Z0zsGqEu6IhM3OckVGJlmPTuNmC/HVlYaCojK2C2Ee/M8z 5TLg== X-Gm-Message-State: APjAAAVrBL6KixfNAmzOWdZuIhj6utUYmFsPYhby/WAvQQzJLZjbcG2j 0XCLQKDpFQtb+xxtunliT1ahjyIHeeEIM5bgAYJHAg== X-Google-Smtp-Source: APXvYqwZVpbtOHL92iEyTM3EmkgPSjCx2Af+TdzU1057vZFBlyDBU0Xbub/hP3q/v8XmhDxndZmJPv23+9MTzdzI/9U= X-Received: by 2002:a2e:9784:: with SMTP id y4mr1318382lji.77.1573113786425; Thu, 07 Nov 2019 00:03:06 -0800 (PST) MIME-Version: 1.0 References: <20191106173125.14496-1-stephan@gerhold.net> <20191106173125.14496-2-stephan@gerhold.net> In-Reply-To: <20191106173125.14496-2-stephan@gerhold.net> From: Linus Walleij Date: Thu, 7 Nov 2019 09:02:55 +0100 Message-ID: Subject: Re: [PATCH 2/2] regulator: ab8500: Remove SYSCLKREQ from enum ab8505_regulator_id To: Stephan Gerhold Cc: Mark Brown , Liam Girdwood , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 6, 2019 at 6:33 PM Stephan Gerhold wrote: > Those regulators are not actually supported by the AB8500 regulator > driver. There is no ab8500_regulator_info for them and no entry in > ab8505_regulator_match. > > As such, they cannot be registered successfully, and looking them > up in ab8505_regulator_match causes an out-of-bounds array read. > > Fixes: 547f384f33db ("regulator: ab8500: add support for ab8505") > Cc: Linus Walleij > Signed-off-by: Stephan Gerhold Reviewed-by: Linus Walleij Yours, Linus Walleij