From: Linus Walleij <linus.walleij@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660
Date: Thu, 16 Jun 2016 09:20:15 +0200 [thread overview]
Message-ID: <CACRpkdb3iiUBTq-BmrsFxWJH4MrUaOTG9WfsCHYUxSYUtZFxvQ@mail.gmail.com> (raw)
In-Reply-To: <20160616002024.GO28218@codeaurora.org>
On Thu, Jun 16, 2016 at 2:20 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 06/15, Linus Walleij wrote:
>> @@ -426,10 +447,11 @@ static irqreturn_t qcom_rpm_ack_interrupt(int irq, void *dev)
>> u32 ack;
>> int i;
>>
>> - ack = readl_relaxed(RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT));
>> - for (i = 0; i < RPM_SELECT_SIZE; i++)
>> - writel_relaxed(0, RPM_CTRL_REG(rpm, RPM_ACK_SELECTOR + i));
>> - writel(0, RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT));
>> + ack = readl_relaxed(RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off));
>> + for (i = 0; i < rpm->data->sel_size; i++)
>> + writel_relaxed(0,
>> + RPM_CTRL_REG(rpm, rpm->data->ack_sel_off + i));
>> + writel(0, RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off));
>
> Does the ack size vary though? I thought that was always 7. It
> seems that really only the request selector size varies?
Ah you're right, I'll send a patch on top of this one fixing it up.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-06-16 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 23:02 [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 Linus Walleij
2016-06-15 8:38 ` Lee Jones
2016-06-16 0:20 ` Stephen Boyd
2016-06-16 7:20 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdb3iiUBTq-BmrsFxWJH4MrUaOTG9WfsCHYUxSYUtZFxvQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).