From: Linus Walleij <linus.walleij@linaro.org>
To: kunyi@google.com
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Tomer Maimon <tmaimon77@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
avifishman70@gmail.com,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: pinctrl-npcm7xx: Set BGPIOF_VOLATILE_REG
Date: Tue, 30 Oct 2018 13:08:14 +0100 [thread overview]
Message-ID: <CACRpkdbS_aOpFORVnK3QJUsF1p-mVxtMas-q6fOp7emTx281Lg@mail.gmail.com> (raw)
In-Reply-To: <20181017213012.233957-3-kunyi@google.com>
On Wed, Oct 17, 2018 at 11:30 PM Kun Yi <kunyi@google.com> wrote:
> Indicate that the pins are both controlled by the pinctrl driver and the
> generic GPIO driver, thus GPIO driver should read the register value
> before updating, instead of using the stored shadow register values.
>
> Signed-off-by: Kun Yi <kunyi@google.com>
This is quite a rough measure, if we instead use regmap-mmio
we can exercise fine control over what register are volatile and
not instead of saying that all of them or some of them are.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-10-30 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 21:30 [PATCH 0/2] Allow gpio-mmio to co-exist with pinctrl driver Kun Yi
2018-10-17 21:30 ` [PATCH 1/2] gpio: gpio-mmio: Allow volatile shadow regs Kun Yi
2018-10-18 11:49 ` kbuild test robot
2018-10-30 12:06 ` Linus Walleij
2018-10-17 21:30 ` [PATCH 2/2] pinctrl: pinctrl-npcm7xx: Set BGPIOF_VOLATILE_REG Kun Yi
2018-10-30 12:08 ` Linus Walleij [this message]
2018-10-31 5:06 ` Kun Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbS_aOpFORVnK3QJUsF1p-mVxtMas-q6fOp7emTx281Lg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=avifishman70@gmail.com \
--cc=broonie@kernel.org \
--cc=kunyi@google.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).