From: Linus Walleij <linus.walleij@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joachim Eastwood <manabian@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate
Date: Wed, 8 Jun 2016 11:04:25 +0200 [thread overview]
Message-ID: <CACRpkdbXmX+eqAFnmjZFG3Xv_gbt-8MtJnpvyWQ5RX-tThez_g@mail.gmail.com> (raw)
In-Reply-To: <1465151023-23340-1-git-send-email-paul.gortmaker@windriver.com>
On Sun, Jun 5, 2016 at 8:23 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> The Kconfig currently controlling compilation of this code is:
>
> config GPIO_LPC18XX
> bool "NXP LPC18XX/43XX GPIO support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> When targeting orphaned modular code in non-modular drivers, this
> came up. Joachim indicated that the driver was actually meant to
> be tristate but ended up bool by accident. So here we make it
> tristate instead of removing the modular code that was essentially
> orphaned.
>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Acked-by: Joachim Eastwood <manabian@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Patch applied.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-06-08 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 18:23 [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate Paul Gortmaker
2016-06-08 9:04 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbXmX+eqAFnmjZFG3Xv_gbt-8MtJnpvyWQ5RX-tThez_g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=gnurou@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).