From: Linus Walleij <linus.walleij@linaro.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
David Wu <david.wu@rock-chips.com>,
heiko.stuebner@bq.com
Subject: Re: [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes
Date: Sat, 17 Nov 2018 13:18:23 +0100 [thread overview]
Message-ID: <CACRpkdbakPGfHap+WcuJ_TVn861zqQDxW-on4q9Wx+-QQb0ESw@mail.gmail.com> (raw)
In-Reply-To: <20181111210047.30375-1-heiko@sntech.de>
On Sun, Nov 11, 2018 at 10:01 PM Heiko Stuebner <heiko@sntech.de> wrote:
> From: Heiko Stuebner <heiko.stuebner@bq.com>
>
> Right now we expect the pin-rounting settings to be in the same area
> as the iomux setting itself. And while that seems to be true for all
> newer Rockchip socs, back in the wild west days of old this wasn't true.
>
> Nowadays pin settings in the GRF normally stay in the GRF and the same
> is true for pins configured from PMU registers. But old socs like the
> rk3188 really sprinkle pin settings somewhat randomly through both
> for its bank0.
>
> Therefore add the option to specify a location for the route setting,
> so that we can map older socs correctly. We'll keep "same" as the
> default, so that we only need to specify a location in the corner-cases
> described above.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
Patch applied with David's review tag.
Yours,
Linus Walleij
prev parent reply other threads:[~2018-11-17 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 21:00 [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes Heiko Stuebner
2018-11-11 21:00 ` [PATCH 2/2] pinctrl: rockchip: add rk3188 routes to switch between nand and emmc Heiko Stuebner
2018-11-17 12:19 ` Linus Walleij
2018-11-14 12:15 ` [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes David Wu
2018-11-17 12:18 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbakPGfHap+WcuJ_TVn861zqQDxW-on4q9Wx+-QQb0ESw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=david.wu@rock-chips.com \
--cc=heiko.stuebner@bq.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).