From: Linus Walleij <linus.walleij@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>,
Xu Wei <xuwei5@hisilicon.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Peter Griffin <peter.griffin@linaro.org>,
Guodong Xu <guodong.xu@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>
Subject: Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values
Date: Sat, 9 Mar 2019 11:50:57 +0100 [thread overview]
Message-ID: <CACRpkdboriy8xym-Czj5g6=3MpiZB8-W45Z62nNQER9S9XsrZQ@mail.gmail.com> (raw)
In-Reply-To: <20190309015635.5401-2-manivannan.sadhasivam@linaro.org>
On Sat, Mar 9, 2019 at 2:59 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
> For the AMBA Primecell devices having the reset lines wired, it is
> necessary to take them out of reset before reading the pid and cid values.
> Earlier we were dependent on the bootloader to do this but a more cleaner
> approach would be to do it in the kernel itself. Hence, this commit
> deasserts the reset line just before reading the pid and cid values.
>
> Suggested-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
This looks correct to me.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I think you can put it in Russell's patch tracker in some week.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-03-09 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 1:56 [PATCH 0/2] Handle I2C and SPI reset on HI6220 SoC Manivannan Sadhasivam
2019-03-09 1:56 ` [PATCH 1/2] amba: Take device out of reset before reading pid and cid values Manivannan Sadhasivam
2019-03-09 10:50 ` Linus Walleij [this message]
2019-03-12 12:27 ` Daniel Thompson
2019-03-20 6:56 ` Manivannan Sadhasivam
2019-03-20 14:29 ` Daniel Thompson
2019-03-20 17:29 ` Russell King - ARM Linux admin
2019-03-21 11:17 ` Daniel Thompson
2019-03-28 16:43 ` Linus Walleij
2019-03-09 1:56 ` [PATCH 2/2] arm64: dts: hisilicon: Add reset properties for HI6220 I2C and SPI Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdboriy8xym-Czj5g6=3MpiZB8-W45Z62nNQER9S9XsrZQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=guodong.xu@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=manivannan.sadhasivam@linaro.org \
--cc=peter.griffin@linaro.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).