From: Ming Lei <tom.leiming@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: switch to scsi-mq by default
Date: Thu, 12 Jul 2018 00:35:17 +0800 [thread overview]
Message-ID: <CACVXFVOSssuveZDN185FUYpjX1i0ma59Cn30XBSJ1dAHDKLnLQ@mail.gmail.com> (raw)
In-Reply-To: <6cf082e4-6fff-21dd-4df5-a6e9e4f2847c@intel.com>
On Wed, Jul 11, 2018 at 4:31 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 11/07/18 05:52, Martin K. Petersen wrote:
>>
>> Johannes,
>>
>>> It has been more than one year since we tried to change the default
>>> from legacy to multi queue in SCSI with commit c279bd9e406 ("scsi:
>>> default to scsi-mq"). But due to issues with suspend/resume and
>>> performance problems it had been reverted again with commit
>>> cbe7dfa26eee ("Revert "scsi: default to scsi-mq"").
>>>
>>> In the meantime there have been a substantial amount of performance
>>> improvements and suspend/resume got fixed as well, thus we can
>>> re-enable scsi-mq without a significant performance penalty.
>>
>> Applied to 4.19/scsi-queue, thanks!
>>
>
> But there is no runtime pm support, is there? I tried enabling runtime PM
> for UFS SCSI devices with scsi-mq and it didn't work, which is a regression.
I just posted one RFC patchset for supporting runtime PM on scsi_mq, and
looks it works in my test on usb-storage.
https://marc.info/?l=linux-block&m=153132657922233&w=2
thanks,
Ming Lei
next prev parent reply other threads:[~2018-07-11 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 8:53 [PATCH] scsi: switch to scsi-mq by default Johannes Thumshirn
2018-07-11 2:52 ` Martin K. Petersen
2018-07-11 8:31 ` Adrian Hunter
2018-07-11 16:35 ` Ming Lei [this message]
2018-07-12 6:17 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACVXFVOSssuveZDN185FUYpjX1i0ma59Cn30XBSJ1dAHDKLnLQ@mail.gmail.com \
--to=tom.leiming@gmail.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=adrian.hunter@intel.com \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).