From: Kalesh Singh <kaleshsingh@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: rjw@rjwysocki.net, Tri Vo <trong@google.com>,
trong@android.com, Sandeep Patil <sspatil@google.com>,
Hridya Valsaraju <hridya@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] PM/sleep: Expose suspend stats in sysfs
Date: Thu, 1 Aug 2019 09:34:22 -0700 [thread overview]
Message-ID: <CAC_TJvdUReRL-Xqq-sSOZ6w1FpEA=Uzys22Mami1USrErnkw+Q@mail.gmail.com> (raw)
In-Reply-To: <20190801061941.GB4338@kroah.com>
On Wed, Jul 31, 2019 at 11:19 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jul 31, 2019 at 02:29:33PM -0700, Kalesh Singh wrote:
> > Userspace can get suspend stats from the suspend stats debugfs node.
> > Since debugfs doesn't have stable ABI, expose suspend stats in
> > sysfs under /sys/power/suspend_stats.
> >
> > Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
> > ---
> > Changes in v2:
> > - Added separate show functions for last_failed_* stats, as per Greg
> > - Updated ABI Documentation
>
> This is nice, I didn't even know some of these were in the debugfs
> entries, so this should be more helpful to people.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for the review Greg :)
next prev parent reply other threads:[~2019-08-01 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 22:52 [PATCH] PM/sleep: Expose suspend stats in sysfs Kalesh Singh
2019-07-31 5:05 ` Greg KH
2019-07-31 21:29 ` [PATCH v2] " Kalesh Singh
2019-08-01 6:19 ` Greg KH
2019-08-01 16:34 ` Kalesh Singh [this message]
2019-08-05 18:29 ` Tri Vo
2019-08-26 9:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC_TJvdUReRL-Xqq-sSOZ6w1FpEA=Uzys22Mami1USrErnkw+Q@mail.gmail.com' \
--to=kaleshsingh@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sspatil@google.com \
--cc=trong@android.com \
--cc=trong@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).