From: Jagan Teki <jagannadh.teki@gmail.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
dri-devel@lists.freedesktop.org,
Gustavo Padovan <gustavo@padovan.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 0/8] drm/sun4i: Allwinner MIPI-DSI support
Date: Fri, 13 Apr 2018 17:48:26 +0530 [thread overview]
Message-ID: <CAD6G_RQrgw2Oopr8uxxev+XN=PERCoR37G7TUur=b=Pvy=6AnA@mail.gmail.com> (raw)
In-Reply-To: <20180413120958.vo4y34q36q2rjyej@flea>
On Fri, Apr 13, 2018 at 5:39 PM, Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
> On Fri, Apr 13, 2018 at 05:30:04PM +0530, Jagan Teki wrote:
>> On Wed, Apr 11, 2018 at 6:13 PM, Maxime Ripard
>> <maxime.ripard@bootlin.com> wrote:
>> > On Wed, Apr 04, 2018 at 11:57:08AM +0200, Maxime Ripard wrote:
>> >> Hi,
>> >>
>> >> Here is an preliminary version of the MIPI-DSI support for the Allwinner
>> >> SoCs.
>> >>
>> >> This controller can be found on a number of recent SoCs, such as the
>> >> A31, A33 or the A64.
>> >>
>> >> Given the sparse documentation, there's a number of obscure areas, but
>> >> the current implementation has been tested with a 4-lanes DSI panel on
>> >> an A33.
>> >>
>> >> The support is a bit rough around the edges at the time, and some artifacts
>> >> are still shown on the screen for some reasons. Wider testing with
>> >> different display will hopefully nail those down.
>> >>
>> >> This needs the regmap_mmio_attach_clk, on its way to Linus in 4.17.
>> >>
>> >> Let me know what you think,
>> >> Maxime
>> >>
>> >> Changes from v3:
>> >> - Rebased on top of current drm-misc-next
>> >> - Switched to SPDX license header
>> >> - Made the ECC array const
>> >> - Split the big DSI patch into two, one to add the DSI driver and one to
>> >> add the TCON bits.
>> >> - Removed the dithering code
>> >> - Changed the DT labels to remove the indices
>> >> - Used sleeps instead of delays in the panel driver
>> >> - Used the backlight_enable / _disable functions
>> >> - Added Chen-Yu's Reviewed-by
>> >>
>> >> Changes from v2:
>> >> - Added a ports node under the DSI node
>> >> - Changed the huarui panel driver to an ili9881c driver
>> >> - Changed the panel vendor to bananapi
>> >> - Made the init table static in the panel driver
>> >> - Dropped the huarui vendor patch for the DT doc.
>> >>
>> >> Changes from v1:
>> >> - Rebased on 4.16-rc1
>> >> - Constified a few function arguments and structures
>> >> - Reworked the DT binding example a bit
>> >> - Reworked the panel driver to check for DSI return codes, and use DCS
>> >> helpers when possible
>> >>
>> >> Maxime Ripard (8):
>> >> drm/sun4i: tcon: Add TRI finish interrupt for vblank
>> >> dt-bindings: display: Add Allwinner MIPI-DSI bindings
>> >> drm/sun4i: Add Allwinner A31 MIPI-DSI controller support
>> >> drm/sun4i: Tie the DSI controller in the TCON
>> >> dt-bindings: panel: Add the Ilitek ILI9881c panel documentation
>> >> drm/panel: Add Ilitek ILI9881c panel driver
>> >> ARM: dts: sun8i: a33: Add the DSI-related nodes
>> >> [DO NOT MERGE] arm: dts: sun8i: bpi-m2m: Add DSI display
>>
>> I have reviewed most of the patches and reused for A64 all look fine
>> to me (except the panel driver). May be my issue is not relevant to
>> this thread, but I'm looking for help If I miss anything for A64 [1]
>> and [2] are changes made for A64, the issue is kernel hang while
>> loading sun6i_dsi.
>
> My guess would be that you're not claiming the DE2 SRAM. See:
> https://lkml.org/lkml/2018/3/16/1096
Thanks Maxime, will try.
prev parent reply other threads:[~2018-04-13 12:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 9:57 [PATCH v4 0/8] drm/sun4i: Allwinner MIPI-DSI support Maxime Ripard
2018-04-04 9:57 ` [PATCH v4 1/8] drm/sun4i: tcon: Add TRI finish interrupt for vblank Maxime Ripard
2018-04-04 9:57 ` [PATCH v4 2/8] dt-bindings: display: Add Allwinner MIPI-DSI bindings Maxime Ripard
2018-04-04 9:57 ` [PATCH v4 3/8] drm/sun4i: Add Allwinner A31 MIPI-DSI controller support Maxime Ripard
2018-04-04 9:57 ` [PATCH v4 4/8] drm/sun4i: Tie the DSI controller in the TCON Maxime Ripard
2018-04-04 9:57 ` [PATCH v4 5/8] dt-bindings: panel: Add the Ilitek ILI9881c panel documentation Maxime Ripard
2018-04-04 9:57 ` [PATCH v4 6/8] drm/panel: Add Ilitek ILI9881c panel driver Maxime Ripard
2018-04-26 15:07 ` Thierry Reding
2018-05-03 13:59 ` Maxime Ripard
2018-04-04 9:57 ` [PATCH v4 7/8] ARM: dts: sun8i: a33: Add the DSI-related nodes Maxime Ripard
2018-04-04 9:57 ` [PATCH v4 8/8] [DO NOT MERGE] arm: dts: sun8i: bpi-m2m: Add DSI display Maxime Ripard
2018-04-11 12:43 ` [PATCH v4 0/8] drm/sun4i: Allwinner MIPI-DSI support Maxime Ripard
2018-04-13 12:00 ` Jagan Teki
2018-04-13 12:09 ` Maxime Ripard
2018-04-13 12:18 ` Jagan Teki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD6G_RQrgw2Oopr8uxxev+XN=PERCoR37G7TUur=b=Pvy=6AnA@mail.gmail.com' \
--to=jagannadh.teki@gmail.com \
--cc=daniel.vetter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).