From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F61C433E0 for ; Fri, 5 Feb 2021 17:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84D5164FFE for ; Fri, 5 Feb 2021 17:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233337AbhBEPlV (ORCPT ); Fri, 5 Feb 2021 10:41:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233319AbhBEPiN (ORCPT ); Fri, 5 Feb 2021 10:38:13 -0500 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F712C061756 for ; Fri, 5 Feb 2021 09:19:48 -0800 (PST) Received: by mail-qk1-x730.google.com with SMTP id t63so7661296qkc.1 for ; Fri, 05 Feb 2021 09:19:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JI+1S8T48pFcr35wnbPxCUfOS4yHFzqI/JgwK92UMUE=; b=Y1KlXeRl60DhAGK1OMQ2+nZVwB9IvEW7Z9d1AmkglS4SBaMjBmSAxjSgSFsRCAHgN0 vJVkxMhWbw5c4oq50K5uIjpwx0/gCXQqsO6PwDU3jVbEph1g/igusmAleN4F9FKli+pI SdBttc3jID0SkLTqmOCF+SOHXFKNIBv9/oqEo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JI+1S8T48pFcr35wnbPxCUfOS4yHFzqI/JgwK92UMUE=; b=U59kdDVjvKeYVob7v1HvtDe3Y3HzKh+PIgewGI3NG/s+2Oah4RiS61jFJGOb7/xMIo f6j73hV+kXXO2+aPVgCtvEndVEFo15mgbswlI0vOmoWo4EF65GRfnKNOe8Ykmiu63i0d 39FbnQ0ZcsFzgeuWvO4uQn59KsMGcANAgxPOtUCg3QsDswji4uIbBXHLR7/TSFu90q8a hY6mtGWqeKiAAR2g14gokn7oYbFBmRlsngQ/642rVguYgO7JQbSDZcCG2RpsEEuxOcxj 3KluDyatgY52dHn0Vf39I8NKBj2lnlGQx/CvcZZgh+30G/9XZwgJrPShSQ5MxkbiMFN0 EJ7g== X-Gm-Message-State: AOAM533UYQod+byKpoUCMoETpBXCDZHLJibaEhXdqPjDQnV+g/3cwTOX 7unQzYRA1CIMLcniwWtZ3cF4gJUVwqulOA== X-Google-Smtp-Source: ABdhPJyauE8TCby6YbaYjWbixlsxw1ZbubH0DDhlCzmcE6yKFd/iAbGB/FTYo19zfiw55efkwiEt1A== X-Received: by 2002:a37:a6d2:: with SMTP id p201mr5403552qke.186.1612545587082; Fri, 05 Feb 2021 09:19:47 -0800 (PST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id y135sm10177499qkb.14.2021.02.05.09.19.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Feb 2021 09:19:46 -0800 (PST) Received: by mail-yb1-f174.google.com with SMTP id m76so7488285ybf.0 for ; Fri, 05 Feb 2021 09:19:45 -0800 (PST) X-Received: by 2002:a25:60d6:: with SMTP id u205mr7882421ybb.276.1612545585241; Fri, 05 Feb 2021 09:19:45 -0800 (PST) MIME-Version: 1.0 References: <20201203202737.7c4wrifqafszyd5y@google.com> <20201208054646.2913063-1-maskray@google.com> In-Reply-To: From: Doug Anderson Date: Fri, 5 Feb 2021 09:19:33 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] firmware_loader: Align .builtin_fw to 8 To: Nick Desaulniers Cc: Andrew Morton , Fangrui Song , Arnd Bergmann , linux-arch , LKML , clang-built-linux , Nathan Chancellor , kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Jan 22, 2021 at 11:04 AM Doug Anderson wrote: > > Hi, > > On Tue, Jan 5, 2021 at 11:20 AM Nick Desaulniers > wrote: > > > > On Tue, Jan 5, 2021 at 9:45 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Mon, Dec 7, 2020 at 9:49 PM Fangrui Song wrote: > > > > > > > > arm64 references the start address of .builtin_fw (__start_builtin_fw) > > > > with a pair of R_AARCH64_ADR_PREL_PG_HI21/R_AARCH64_LDST64_ABS_LO12_NC > > > > relocations. The compiler is allowed to emit the > > > > R_AARCH64_LDST64_ABS_LO12_NC relocation because struct builtin_fw in > > > > include/linux/firmware.h is 8-byte aligned. > > > > > > > > The R_AARCH64_LDST64_ABS_LO12_NC relocation requires the address to be a > > > > multiple of 8, which may not be the case if .builtin_fw is empty. > > > > Unconditionally align .builtin_fw to fix the linker error. 32-bit > > > > architectures could use ALIGN(4) but that would add unnecessary > > > > complexity, so just use ALIGN(8). > > > > > > > > Fixes: 5658c76 ("firmware: allow firmware files to be built into kernel image") > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1204 > > > > Reported-by: kernel test robot > > > > Signed-off-by: Fangrui Song > > > > Acked-by: Arnd Bergmann > > > > > > > > --- > > > > Change in v2: > > > > * Use output section alignment instead of inappropriate ALIGN_FUNCTION() > > > > --- > > > > include/asm-generic/vmlinux.lds.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Tested-by: Douglas Anderson > > > > > > For whatever reason this is hitting developers on Chrome OS a whole > > > lot suddenly. Any chance it could be landed? Which tree should it go > > > through? > > > > Andrew, > > Would you mind picking up this patch for us, please? > > https://lore.kernel.org/lkml/20201208054646.2913063-1-maskray@google.com/ > > I just synced today and I'm still hitting this error when building > mainline. Perhaps Andrew is busy and someone else can pick it up? > It'd be nice to get this into v5.11 I hate to be a broken record, but I synced and built mainline today (v5.11-rc6-139-gdd86e7fa07a3) and I'm still hitting this. It feels like we need an alternate way to get this landed... -Doug