From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932528AbbKQVXA (ORCPT ); Tue, 17 Nov 2015 16:23:00 -0500 Received: from mail-yk0-f174.google.com ([209.85.160.174]:36039 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754803AbbKQVW4 (ORCPT ); Tue, 17 Nov 2015 16:22:56 -0500 MIME-Version: 1.0 In-Reply-To: <1447721484-22548-7-git-send-email-dianders@chromium.org> References: <1447721484-22548-1-git-send-email-dianders@chromium.org> <1447721484-22548-7-git-send-email-dianders@chromium.org> Date: Tue, 17 Nov 2015 13:22:55 -0800 X-Google-Sender-Auth: AO5yWO-wqYV8ZQ_zIZ1KQAy4NA0 Message-ID: Subject: Re: [PATCH v3 6/8] usb: dwc2: host: Assume all devices are on one single_tt hub From: Doug Anderson To: John Youn , Felipe Balbi Cc: Yunzhi Li , =?UTF-8?Q?Heiko_St=C3=BCbner?= , "open list:ARM/Rockchip SoC..." , Julius Werner , "Herrero, Gregory" , "Kaukab, Yousaf" , Dinh Nguyen , Alan Stern , Ming Lei , Douglas Anderson , John Youn , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Nov 16, 2015 at 4:51 PM, Douglas Anderson wrote: > Until we have logic to determine which devices share the same TT let's > add logic to assume that all devices on a given dwc2 controller are on > one single_tt hub. This is better than the previous code that assumed > that all devices were on one multi_tt hub, since single_tt hubs > appear (in my experience) to be much more common and any schedule that > would work on a single_tt hub will also work on a multi_tt hub. This > will prevent more than 8 total low/full speed devices to be on the bus > at one time, but that's a reasonable restriction until we've made things > smarter. > > Signed-off-by: Douglas Anderson > --- > Changes in v3: > - Assuming single_tt is new for v3; not terribly well tested (yet). > > Changes in v2: None > > drivers/usb/dwc2/core.h | 1 + > drivers/usb/dwc2/hcd_queue.c | 40 +++++++++++++++++++++++++++++++++++++++- > 2 files changed, 40 insertions(+), 1 deletion(-) Just as a FYI I managed to make this a little better with , but not posting that yet because Julius has pointed out some things offline that I could be doing better (actually schedule the low speed bus properly). I'll hopefully post something more soon... -Doug