From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD0CC04FF3 for ; Mon, 24 May 2021 21:09:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8C3A6140F for ; Mon, 24 May 2021 21:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233723AbhEXVKl (ORCPT ); Mon, 24 May 2021 17:10:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232859AbhEXVKk (ORCPT ); Mon, 24 May 2021 17:10:40 -0400 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 725DFC061574 for ; Mon, 24 May 2021 14:09:09 -0700 (PDT) Received: by mail-qv1-xf33.google.com with SMTP id z1so14940833qvo.4 for ; Mon, 24 May 2021 14:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cb0Uq1HaIEgENxGmHlcF9aKNMAXuk7VxGUnLZxEoKmU=; b=ntnzKyxJBJ7zU41VapDr35r0+JiHT8LcMIOT1SR4I6dP7Nrl9EK73MZQzrTWVv2G/a TvLKeWmsqGVaLQw7mwVv23fZ6u/EttxAw0FagUfXUq1zL12KWaqXnLByBCoKE5F7om18 zGL5EynggjpTSTpu9EBvXFi+MSf3PrIlYRTSY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cb0Uq1HaIEgENxGmHlcF9aKNMAXuk7VxGUnLZxEoKmU=; b=nyXDE55xJOLFg+2JfyG2fQhgR4gHyknhnCf9KDXhDyjcnICB9NF0ysomkYTbQvVaCC IIjE1j4tRRJqlN41kJvnzJO1KVlUAdI3VuI3YIIXH5kVr9ks9SvytEtbncRTM3fgOaFn OGA/Hxyz8zbM/OyOYcbmr35/qC/D7Jr0DNLmmJdXHymTUber9G2bVUYbbR+MpsZ5Obgq UOxWdV5kjw/vo3tkDeeNfnLWbDqabS186WZUCNsORr5Lzo9MKdqP9oOSiXlkt0kWeUVL /BDmMjmNba66d5yiIkUD9lntCKRIfD+mG1YQY5+gcH5mS7PqhHZ+SOpiHugwZAd1XbCJ hpEA== X-Gm-Message-State: AOAM5339ycnNUWDnGvF9jxz3x/e8Kln4IKho6iGpz6Z/liLjPEMuWqBC 8hsDAERYkOCe2B8SFMjxDvZLnYHIbChlVw== X-Google-Smtp-Source: ABdhPJzrHEBvgXzHmvud+2q52l9RwtKVq6BMZROBGyp3N+AOLqnsjlok4aHaqQW00We19VBh9/8s4Q== X-Received: by 2002:a0c:d80f:: with SMTP id h15mr10390958qvj.17.1621890548264; Mon, 24 May 2021 14:09:08 -0700 (PDT) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id h16sm11146057qke.43.2021.05.24.14.09.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 14:09:07 -0700 (PDT) Received: by mail-yb1-f179.google.com with SMTP id w206so8277438ybg.7 for ; Mon, 24 May 2021 14:09:07 -0700 (PDT) X-Received: by 2002:a25:b801:: with SMTP id v1mr2108952ybj.32.1621890546699; Mon, 24 May 2021 14:09:06 -0700 (PDT) MIME-Version: 1.0 References: <20210517200907.1459182-1-dianders@chromium.org> <20210517130450.v7.1.I9e947183e95c9bd067c9c1d51208ac6a96385139@changeid> In-Reply-To: From: Doug Anderson Date: Mon, 24 May 2021 14:08:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 01/10] drm/panel: panel-simple: Add missing pm_runtime_dont_use_autosuspend() calls To: Laurent Pinchart Cc: Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Rob Clark , David Airlie , linux-arm-msm , Stephen Boyd , dri-devel , Bjorn Andersson , Stanislav Lisovskiy , Thierry Reding , Steev Klimaszewski , Thierry Reding , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, May 24, 2021 at 1:22 PM Laurent Pinchart wrote: > > Hi Doug, > > Thank you for the patch. > > On Mon, May 17, 2021 at 01:08:58PM -0700, Douglas Anderson wrote: > > The PM Runtime docs specifically call out the need to call > > pm_runtime_dont_use_autosuspend() in the remove() callback if > > pm_runtime_use_autosuspend() was called in probe(): > > > > > Drivers in ->remove() callback should undo the runtime PM changes done > > > in ->probe(). Usually this means calling pm_runtime_disable(), > > > pm_runtime_dont_use_autosuspend() etc. > > ~/src/kernel/linux $ git grep pm_runtime_use_autosuspend -- drivers | wc -l > 209 > ~/src/kernel/linux $ git grep pm_runtime_dont_use_autosuspend -- drivers | wc -l > 80 > > Seems like a lost battle :-( > > The fix is right, but I wonder if this shouldn't be handled > automatically by the runtime PM core. The runtime PM API is notoriously > difficult to use correctly. No kidding. > > We should do this. This fixes a warning splat that I saw when I was > > testing out the panel-simple's remove(). > > > > Fixes: 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare") > > Signed-off-by: Douglas Anderson > > Reviewed-by: Laurent Pinchart Thanks! I have pushed just this patch for now. -Doug