From: Doug Anderson <dianders@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
David Collins <collinsd@codeaurora.org>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone
Date: Thu, 28 Jun 2018 15:58:41 -0700 [thread overview]
Message-ID: <CAD=FV=Wo4wc_QZYr0a2_Ge=B6T4RNJDnOyxAd8r6sT4iZJjCKg@mail.gmail.com> (raw)
In-Reply-To: <20180628210915.160893-3-mka@chromium.org>
Hi,
On Thu, Jun 28, 2018 at 2:09 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> Add pm8998 thermal zone based on the examples in the spmi-temp-alarm
> bindings.
>
> Note: devices with the pm8998 need to have a 'thermal-zones' node (which
> may be empty) with a label 'thermal_zones'.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/pm8998.dtsi | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
Do you know if this patch actually does anything since you didn't
define a cooling-maps? Hopefully at least the critical shuts things
down?
Do you have any idea how we'll eventually want to specify a
cooling-maps? Are we just going to assume we're included by an sdm845
device and refer to the big/little CPU phandles?
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index f2d39074ed74..d85ceb4f976b 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -3,6 +3,7 @@
>
> #include <dt-bindings/spmi/spmi.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/thermal/thermal.h>
>
> &spmi_bus {
> pm8998_lsid0: pmic@0 {
> @@ -59,3 +60,30 @@
> #size-cells = <0>;
> };
> };
> +
> +&thermal_zones {
As per comments in patch #1, don't rely on a label. Just put your
stuff in a top-level "thermal-zones" node.
> + pm8998 {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = <&pm8998_temp>;
> +
> + trips {
> + passive {
IMO you should proactively put a label on these trips even if there's
no cooling device yet. It's expected that at some point someone will
add a cooling device and refer to them, right?
-Doug
next prev parent reply other threads:[~2018-06-28 22:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:09 [PATCH 1/3] arm64: dts: qcom: sdm845: Add thermal-zones node Matthias Kaehlcke
2018-06-28 21:09 ` [PATCH 2/3] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node Matthias Kaehlcke
2018-06-28 21:09 ` [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone Matthias Kaehlcke
2018-06-28 22:58 ` Doug Anderson [this message]
2018-06-29 18:51 ` Matthias Kaehlcke
2018-06-29 21:29 ` David Collins
2018-06-29 23:54 ` Matthias Kaehlcke
2018-07-10 17:45 ` David Collins
2018-07-11 21:56 ` Doug Anderson
2018-07-11 22:36 ` David Collins
2018-07-11 22:43 ` Doug Anderson
2018-07-11 22:53 ` Matthias Kaehlcke
2018-07-12 0:10 ` David Collins
2018-07-13 16:49 ` Matthias Kaehlcke
2018-06-28 22:52 ` [PATCH 1/3] arm64: dts: qcom: sdm845: Add thermal-zones node Doug Anderson
2018-06-29 18:30 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Wo4wc_QZYr0a2_Ge=B6T4RNJDnOyxAd8r6sT4iZJjCKg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=collinsd@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).