From: Doug Anderson <dianders@chromium.org>
To: Rob Clark <robdclark@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rob Clark <robdclark@chromium.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jordan Crouse <jcrouse@codeaurora.org>
Subject: Re: [RFC 3/3] arm64: dts: qcom: sdm845-cheza: delete zap-shader
Date: Wed, 15 May 2019 14:43:13 -0700 [thread overview]
Message-ID: <CAD=FV=Xa0kAReU7CFvO8QiCRkNxGaQY_JohK+psykqeN9e+QJw@mail.gmail.com> (raw)
In-Reply-To: <20190509184415.11592-4-robdclark@gmail.com>
Hi,
On Thu, May 9, 2019 at 12:08 PM Rob Clark <robdclark@gmail.com> wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> This is unused on cheza. Delete the node to get rid of the reserved-
> memory section, and to avoid the driver from attempting to load a zap
> shader that doesn't exist every time it powers up the GPU.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 ++
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
nit: up to Bjorn / Andy, but personally I'd put cheza and non-cheza
changes in two patches.
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> index 8ccbe246dff4..28c28517b21a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> @@ -175,6 +175,8 @@
> /delete-node/ &venus_mem;
> /delete-node/ &cdsp_mem;
> /delete-node/ &cdsp_pas;
> +/delete-node/ &zap_shader;
nit: I'd probably move the delete of the zap shader to a slightly
different place just because the rest of the lines here are deleting
reserved memory regions.
Other than nits this seems OK to me. Not that I know anything about
the zap shader or why a zap shader wouldn't be appropriate for cheza.
-Doug
prev parent reply other threads:[~2019-05-15 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190509184415.11592-1-robdclark@gmail.com>
2019-05-09 18:44 ` [RFC 1/3] arm64: dts: qcom: sdm845-cheza: add initial cheza dt Rob Clark
2019-05-13 22:47 ` Doug Anderson
2019-05-09 18:44 ` [RFC 2/3] arm64: dts: qcom: sdm845-cheza: Re-add reserved memory Rob Clark
2019-05-13 22:48 ` Doug Anderson
2019-05-15 4:09 ` Rob Clark
2019-05-15 19:24 ` Jordan Crouse
2019-05-15 21:50 ` Doug Anderson
2019-05-15 23:41 ` Bjorn Andersson
2019-05-09 18:44 ` [RFC 3/3] arm64: dts: qcom: sdm845-cheza: delete zap-shader Rob Clark
2019-05-15 21:43 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Xa0kAReU7CFvO8QiCRkNxGaQY_JohK+psykqeN9e+QJw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).