From: Baolin Wang <baolin.wang7@gmail.com>
To: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>
Subject: Re: [PATCH 2/2] clk: sprd: return correct type of value for _sprd_pll_recalc_rate
Date: Tue, 19 May 2020 21:13:01 +0800 [thread overview]
Message-ID: <CADBw62oep+5n+9d5Qmzj7HR4u5JXTp2qSi2ipDHFAemK5Wcjpg@mail.gmail.com> (raw)
In-Reply-To: <20200519030036.1785-2-zhang.lyra@gmail.com>
On Tue, May 19, 2020 at 11:00 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
>
> The function _sprd_pll_recalc_rate() defines return value to unsigned
> long, but it would return a negative value when malloc fail, changing
> to return its parent_rate makes more sense, since if the callback
> .recalc_rate() is not set, the framework returns the parent_rate as
> well.
>
> Fixes: 3e37b005580b ("clk: sprd: add adjustable pll support")
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Looks good to me.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
--
Baolin Wang
next prev parent reply other threads:[~2020-05-19 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 3:00 [PATCH 1/2] clk: sprd: mark the local clock symbols static Chunyan Zhang
2020-05-19 3:00 ` [PATCH 2/2] clk: sprd: return correct type of value for _sprd_pll_recalc_rate Chunyan Zhang
2020-05-19 13:13 ` Baolin Wang [this message]
2020-05-27 3:14 ` Stephen Boyd
2020-05-19 13:12 ` [PATCH 1/2] clk: sprd: mark the local clock symbols static Baolin Wang
2020-05-27 3:14 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADBw62oep+5n+9d5Qmzj7HR4u5JXTp2qSi2ipDHFAemK5Wcjpg@mail.gmail.com \
--to=baolin.wang7@gmail.com \
--cc=chunyan.zhang@unisoc.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orsonzhai@gmail.com \
--cc=sboyd@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).