From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1581C433FF for ; Tue, 13 Aug 2019 14:01:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B679720840 for ; Tue, 13 Aug 2019 14:01:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XQe6qEES" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729449AbfHMOBV (ORCPT ); Tue, 13 Aug 2019 10:01:21 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52987 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727561AbfHMOBV (ORCPT ); Tue, 13 Aug 2019 10:01:21 -0400 Received: by mail-wm1-f68.google.com with SMTP id o4so1497362wmh.2; Tue, 13 Aug 2019 07:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ky/0G1r/E47b3qMLySEW2K0XYi/tp5CsA6kbQT1Docg=; b=XQe6qEESNVu+84o4mpV5IxOP2tMWBF13A5AN5TPmm/op1NRmPd4aktWCNwQXabIi7B fXY+jgumHgPnZREKODcMeVrB7KU04CuH1SH55gsE02AQWXpSvKBdSXw2iIyyjmMQdfPe H4MTrbDzEDVQBgTjLd4kQHxld74QGElq76UZGX5/yhOS9Aw8Q91vfgb5k7gXTVmIywQP Y8lzROWvFROz6fJ7Pamrqvb8IgOuoKIpZbxZXQ0PgcYYBN+tmEtVaNODLQxdfSQHbKvZ gkNgfQxY9LPnXuU8sR/p2BfmQxvgQ91A8gCzkdKQIkA0IzIknY/wB1rWOkzZmLUIEban xYeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ky/0G1r/E47b3qMLySEW2K0XYi/tp5CsA6kbQT1Docg=; b=aFxwRgRkmihJ7tgZv+Ymf8C1ah2Lu1Dsn2yyUhHYbQAb+Z1RohTrXdSiS0pC83J0fM R1OJDDsToP+aX6rqod1BRDJuvZE8khkEUROGSQl0+6PzqVDj81NoReQFohf4T+cr14qY oT6lUGT5MbSPFQ6Q0SLxn5TYhKysw3Uytb/CaO7CuygjaUtIr+nkVxNMNBig293tg+Ze VmBTXp1bTIvPc811+ck3hvjQP/YBVr4rnT1xQQsg3TBV/+lQ03l2EFFaM2dFRfGfiLjU AZmbKoRGl8fzH2Jt+xQjbLvRr8Dg7SjRfkgBQF8PC0mePlONKzM9zgwIXIMUedSa2CYD qimQ== X-Gm-Message-State: APjAAAUQbtDSLmNLpRkZfprEwi3YOHNQdPn43T7r27oz4HqTPN7nDw2N ckwzYJ6ruz8U+yAdK+Kx/+nE9zYg9lwVx/i0frMdGw== X-Google-Smtp-Source: APXvYqw0zbnDhh4DoH9t3jQVCRnpoZ6VJUK22NeN6UMrTRQB4NrXBEh1FXH9qFACsgkt1dFtqQfiMO8ZNbOh03Mn11E= X-Received: by 2002:a1c:1d42:: with SMTP id d63mr3197633wmd.34.1565704878839; Tue, 13 Aug 2019 07:01:18 -0700 (PDT) MIME-Version: 1.0 References: <20190813181038.2c6aafb9@canb.auug.org.au> In-Reply-To: From: Alex Deucher Date: Tue, 13 Aug 2019 10:01:07 -0400 Message-ID: Subject: Re: linux-next: build failure after merge of the amdgpu tree To: "Huang, Ray" Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , "Liu, Aaron" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 13, 2019 at 4:21 AM Huang, Ray wrote: > > > -----Original Message----- > > From: Stephen Rothwell > > Sent: Tuesday, August 13, 2019 4:11 PM > > To: Alex Deucher > > Cc: Linux Next Mailing List ; Linux Kernel > > Mailing List ; Liu, Aaron > > ; Huang, Ray > > Subject: linux-next: build failure after merge of the amdgpu tree > > > > Hi all, > > > > After merging the amdgpu tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/gpu/drm/amd/amdgpu/psp_v12_0.c:39:17: error: expected > > declaration specifiers or '...' before string constant > > MODULE_FIRMWARE("amdgpu/renoir_asd.bin"); > > ^~~~~~~~~~~~~~~~~~~~~~~ > > > > Caused by commit > > > > 6a7a0bdbfa0c ("drm/amdgpu: add psp_v12_0 for renoir (v2)") > > > > I have applied the following patch for today: > > > > From: Stephen Rothwell > > Date: Tue, 13 Aug 2019 18:03:16 +1000 > > Subject: [PATCH] drm/amdgpu: MODULE_FIRMWARE requires > > linux/module.h > > > > Fixes: 6a7a0bdbfa0c ("drm/amdgpu: add psp_v12_0 for renoir (v2)") > > Signed-off-by: Stephen Rothwell > > Thanks! > > Reviewed-by: Huang Rui > Applied. thanks! Alex > > --- > > drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c > > b/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c > > index f37b8af4b986..b474dfb79375 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c > > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c > > @@ -21,6 +21,7 @@ > > */ > > > > #include > > +#include > > #include "amdgpu.h" > > #include "amdgpu_psp.h" > > #include "amdgpu_ucode.h" > > -- > > 2.20.1 > > > > -- > > Cheers, > > Stephen Rothwell