From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73A9C4320A for ; Fri, 23 Jul 2021 20:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0DDC60F35 for ; Fri, 23 Jul 2021 20:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231370AbhGWTc1 (ORCPT ); Fri, 23 Jul 2021 15:32:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbhGWTc0 (ORCPT ); Fri, 23 Jul 2021 15:32:26 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B8EFC061575 for ; Fri, 23 Jul 2021 13:12:59 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id y18so3123210oiv.3 for ; Fri, 23 Jul 2021 13:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=iWKsxqaLuKKt7r1ybco35OuqISL9Q6eRrAXI7L+rDDo=; b=PPzW/qAs5wuxrT5U0bkozRW2HaxMAaUGE3JwrNMv8MPBBWl9h1FmY7g4/+it3cHcar UQxysCb003ez8WPNpFgmkTNQTcxzGwl3BYhl7dhr6jJG8b1RthNcgdl9xqckEJ6hcnsG 09Gkppkoi2B2IF9te3kllT2T00TY+Akg6DoHw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=iWKsxqaLuKKt7r1ybco35OuqISL9Q6eRrAXI7L+rDDo=; b=iy9yd2H7J1zi8mf4nhs+XMDyawfW4KdO4L6mcierWNVy0+L/6d9ujG9CHxxXrDXXKc P0eMWWVLCCyGyt+Xqon5GOh765V1Cd+4rXPAVlEuV5ARdp/0RAQvz4dW7G4Miz7sfxwd suKxMPZhgth4ZATbzCNaPUhWh6xHL/Wen5q4kNEoXkvaCeapfFHha5M0akZVStDYSjkO ABVg5/yEq00mHEJUigb7vC6nD1UppUde/l5wuwr6qR4xSbT+2kTBboRm0oZ25svzAO9D 8F7Wt83N7ccWB2zSDDGkoHVXcUPvK4YUizkoKETGEllY7VagPPRTcTnzUiCftcrxPP/8 pMlA== X-Gm-Message-State: AOAM531fAAoSj7KjXIfHA6zD9ebHBdv3sWuofchrnif1F/NzkTkH8ow4 jhs8LG1jMzQ2Q9X9uRmIg72FBMkSkXWb+l57Ksosjw== X-Google-Smtp-Source: ABdhPJychER1jemf23dOU3zqarRWN2XH+0UzO49bwOXeyzNfynn0OHwpFypLFF9y16OeQTr1wy7vpfKtK5Ue9RNQPcM= X-Received: by 2002:aca:4dc6:: with SMTP id a189mr10234216oib.166.1627071178884; Fri, 23 Jul 2021 13:12:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 23 Jul 2021 20:12:58 +0000 MIME-Version: 1.0 In-Reply-To: References: From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 23 Jul 2021 20:12:58 +0000 Message-ID: Subject: Re: [PATCH] Input: pm8941-pwrkey - fix comma vs semicolon issue To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Bjorn Andersson , David Collins , satya priya , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Dmitry Torokhov (2021-07-23 12:52:15) > On Fri, Jul 23, 2021 at 07:43:52PM +0000, Stephen Boyd wrote: > > Quoting Dmitry Torokhov (2021-07-23 12:39:02) > > > There is absolutely no reason to use comma operator in this code, 2 > > > separate statements make much more sense. > > > > > > Signed-off-by: Dmitry Torokhov > > > --- > > > > Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350 > > PON_HLOS PMIC peripheral") > > It actually predates this patch and also not really a fix as the > original code ends up working properly, but looks weird. Alright.