From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 377DEC433EF for ; Thu, 30 Sep 2021 17:58:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A21E61994 for ; Thu, 30 Sep 2021 17:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352925AbhI3SAR (ORCPT ); Thu, 30 Sep 2021 14:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352882AbhI3SAK (ORCPT ); Thu, 30 Sep 2021 14:00:10 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2DB1C06176C for ; Thu, 30 Sep 2021 10:58:27 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id a3so8364343oid.6 for ; Thu, 30 Sep 2021 10:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=ODaJrzhlII7IaX+qlNLhzszeBmnqReAaw8HMQDA91KQ=; b=bTQg8VLL960aI4MFPT4bL+ziwayamEyzDehDR1iOJFMPkxj/2Nk4rKVj9YVCEdzD6b UrAEhn7yK+oZWFVFV9a2Vsk+1xTPbIH4KRcCLTJq6nYecBRghntzlrD0p0OATanZSj0t St0+87W3xKmk6mTdbO+IC0+LpfWha2ZwUXZQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=ODaJrzhlII7IaX+qlNLhzszeBmnqReAaw8HMQDA91KQ=; b=qJTDOSwe9b4Z57/+eDlO8kE8oRMYpFxPzyZaRpQur7N6yh1sx0C5YR4h8vRYUtZt8L XmtG5dWAB94CVJvznIRHfBD+cuulmfSyWEVkN0UoH9cTJ3V7OKDnm6VWBbLMIhp2s0Rv tEF55rsbZUc+mZy/R3jJ5exil67MeQA0R+A1PMpeqQF4IMb2ogWP+odLU2PhKKjngdD7 BC7HMa6n1SZy2dCF/jIbd+qXdVItm465NFPS0fqX476xMPFQ7LsBc0zifbpDfoH6BgjO iF6JgWRxOd3du37rKfS+HFTFR7R3Bl7BcT+WCFQ7e/ICqaviK9CVOrWQY28BNbBjGxmx CRZg== X-Gm-Message-State: AOAM5329epTj5GaHJwXTsyF3Gh7w3aQiqRD3A1VEtuyydhAdz4BwKWfC knDDRLn/tOw+g3KXRgjIVWwrSIJMqmC+hzseTkhEBg== X-Google-Smtp-Source: ABdhPJx0TbzSitN4I1kanbYg8IkdrXr3mPw09WhLirZ71+GW8AkE5QIIHBvLl1NRDRFk/IIUhiDGGlyQIyMalzrBWvE= X-Received: by 2002:aca:42d7:: with SMTP id p206mr501591oia.32.1633024707214; Thu, 30 Sep 2021 10:58:27 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 30 Sep 2021 10:58:26 -0700 MIME-Version: 1.0 In-Reply-To: <5adf2ab2c2a162272509d253bd797721@codeaurora.org> References: <1629282424-4070-1-git-send-email-mkrishn@codeaurora.org> <1629282424-4070-2-git-send-email-mkrishn@codeaurora.org> <5adf2ab2c2a162272509d253bd797721@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 30 Sep 2021 10:58:26 -0700 Message-ID: Subject: Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes To: mkrishn@codeaurora.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kalyan_t@codeaurora.org, sbillaka@codeaurora.org, abhinavk@codeaurora.org, robdclark@gmail.com, bjorn.andersson@linaro.org, khsieh@codeaurora.org, rajeevny@codeaurora.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting mkrishn@codeaurora.org (2021-09-30 04:56:59) > On 2021-08-19 01:27, Stephen Boyd wrote: > > Quoting Krishna Manikandan (2021-08-18 03:27:02) > >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> index 53a21d0..fd7ff1c 100644 > >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> + > >> + status = "disabled"; > >> + > >> + mdp: mdp@ae01000 { > > > > display-controller@ae01000 > > Stephen, > In the current driver code, there is a substring comparison for "mdp" > in device node name as part of probe sequence. If "mdp" is not present > in the node name, it will > return an error resulting in probe failure. Can we continue using mdp > as nodename instead of display controller? > Can we fix the driver to not look for node names and look for compatible strings instead? It took me a minute to find compare_name_mdp() in drivers/gpu/drm/msm/msm_drv.c to understand what you're talking about. Perhaps looking for qcom,mdp5 in there will be sufficient instead of looking at the node name.