From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
DaeLyong Jeong <threeearcat@gmail.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Byoungyoung Lee <byoungyoung@purdue.edu>,
Kyungtae Kim <kt0755@gmail.com>,
bammanag@purdue.edu, Willem de Bruijn <willemb@google.com>
Subject: Re: WARNING in ip_recv_error
Date: Fri, 18 May 2018 13:09:37 -0400 [thread overview]
Message-ID: <CAF=yD-Kb4ZfJ3sMAnWEOB_s9Y=TTnLbRZxrDPiGZLO=trPjY5Q@mail.gmail.com> (raw)
In-Reply-To: <20180518.114433.390752642781753429.davem@davemloft.net>
On Fri, May 18, 2018 at 11:44 AM, David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 18 May 2018 08:30:43 -0700
>
>> We probably need to revert Willem patch (7ce875e5ecb8562fd44040f69bda96c999e38bbc)
>
> Is it really valid to reach ip_recv_err with an ipv6 socket?
I guess the issue is that setsockopt IPV6_ADDRFORM is not an
atomic operation, so that the socket is neither fully ipv4 nor fully
ipv6 by the time it reaches ip_recv_error.
sk->sk_socket->ops = &inet_dgram_ops;
< HERE >
sk->sk_family = PF_INET;
Even calling inet_recv_error to demux would not necessarily help.
Safest would be to look up by skb->protocol, similar to what
ipv6_recv_error does to handle v4-mapped-v6.
Or to make that function safe with PF_INET and swap the order
of the above two operations.
All sound needlessly complicated for this rare socket option, but
I don't have a better idea yet. Dropping on the floor is not nice,
either.
next prev parent reply other threads:[~2018-05-18 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 12:08 WARNING in ip_recv_error DaeRyong Jeong
2018-05-18 15:30 ` Eric Dumazet
2018-05-18 15:44 ` David Miller
2018-05-18 17:09 ` Willem de Bruijn [this message]
2018-05-18 18:44 ` Willem de Bruijn
2018-05-18 18:46 ` Willem de Bruijn
2018-05-18 18:59 ` Willem de Bruijn
2018-05-20 23:13 ` Willem de Bruijn
2018-05-23 15:40 ` Willem de Bruijn
2018-05-23 18:30 ` Willem de Bruijn
2018-05-24 8:00 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-Kb4ZfJ3sMAnWEOB_s9Y=TTnLbRZxrDPiGZLO=trPjY5Q@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=bammanag@purdue.edu \
--cc=byoungyoung@purdue.edu \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kt0755@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=threeearcat@gmail.com \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).