From: Sumit Garg <sumit.garg@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: kgdb-bugreport@lists.sourceforge.net,
Jason Wessel <jason.wessel@windriver.com>,
Douglas Anderson <dianders@chromium.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] kdb: Make kdb_printf robust to run in NMI context
Date: Thu, 28 May 2020 13:12:40 +0530 [thread overview]
Message-ID: <CAFA6WYNY1tk=Md84tuSHOBgmB330eAAV8yWM1XLT0sDcbWus6A@mail.gmail.com> (raw)
In-Reply-To: <20200527142617.t7dzal7ok5i3exra@holly.lan>
On Wed, 27 May 2020 at 19:56, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>
> On Wed, May 27, 2020 at 11:55:58AM +0530, Sumit Garg wrote:
> > While rounding up CPUs via NMIs, its possible that a rounded up CPU
>
> This problem does not just impact NMI roundup (breakpoints,
I guess here via breakpoints you meant if we add a compiled breakpoint
or runtime breakpoint in console handler code while its holding the
spin lock could lead to a deadlock, correct?
> including
> implicit breakpoint-on-oops can have the same effect).
>
Isn't the breakpoint-on-oops case already handled via bust_spinlocks()
usage in panic handler here [1]?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/kernel/panic.c#n207
>
> > maybe holding a console port lock leading to kgdb master CPU stuck in
> > a deadlock during invocation of console write operations. So in order
> > to avoid such a deadlock, enable oops_in_progress prior to invocation
> > of console handlers.
> >
> > Suggested-by: Petr Mladek <pmladek@suse.com>
> > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > ---
> > kernel/debug/kdb/kdb_io.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
> > index 349dfcc..f848482 100644
> > --- a/kernel/debug/kdb/kdb_io.c
> > +++ b/kernel/debug/kdb/kdb_io.c
> > @@ -566,7 +566,17 @@ static void kdb_msg_write(char *msg, int msg_len)
> > for_each_console(c) {
> > if (!(c->flags & CON_ENABLED))
> > continue;
> > + /*
> > + * While rounding up CPUs via NMIs, its possible that
>
> Ditto.
>
> > + * a rounded up CPU maybe holding a console port lock
> > + * leading to kgdb master CPU stuck in a deadlock during
> > + * invocation of console write operations. So in order
> > + * to avoid such a deadlock, enable oops_in_progress
> > + * prior to invocation of console handlers.
>
> Actually looking at this comment as a whole I think it spends to many
> words on what and not enough on why (e.g. what the tradeoffs are and
> why we are not using bust_spinlocks() which would be a more obvious
> approach).
>
> Set oops_in_progress to encourage the console drivers to disregard
> their internal spin locks: in the current calling context
> the risk of deadlock is a bigger problem than risks due to
> re-entering the console driver. We operate directly on
> oops_in_progress rather than using bust_spinlocks() because
> the calls bust_spinlocks() makes on exit are not appropriate
> for this calling context.
Sounds reasonable, will use it instead.
-Sumit
>
>
> Daniel.
>
>
> > + */
> > + ++oops_in_progress;
> > c->write(c, msg, msg_len);
> > + --oops_in_progress;
> > touch_nmi_watchdog();
> > }
> > }
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2020-05-28 7:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 6:25 [PATCH v3 0/4] kdb: Improve console handling Sumit Garg
2020-05-27 6:25 ` [PATCH v3 1/4] kdb: Re-factor kdb_printf() message write code Sumit Garg
2020-05-27 8:29 ` Daniel Thompson
2020-05-27 10:01 ` Sumit Garg
2020-05-27 6:25 ` [PATCH v3 2/4] kdb: Check status of console prior to invoking handlers Sumit Garg
2020-05-27 14:26 ` Daniel Thompson
2020-05-27 6:25 ` [PATCH v3 3/4] kdb: Make kdb_printf robust to run in NMI context Sumit Garg
2020-05-27 14:26 ` Daniel Thompson
2020-05-28 7:42 ` Sumit Garg [this message]
2020-05-27 6:25 ` [PATCH v3 4/4] kdb: Switch kdb_msg_write() to use safer polling I/O Sumit Garg
2020-05-27 13:31 ` Daniel Thompson
2020-05-28 6:18 ` Sumit Garg
2020-05-28 11:26 ` Daniel Thompson
2020-05-28 14:57 ` Petr Mladek
2020-05-29 5:46 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFA6WYNY1tk=Md84tuSHOBgmB330eAAV8yWM1XLT0sDcbWus6A@mail.gmail.com' \
--to=sumit.garg@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).