From: Alexey Klimov <aklimov@redhat.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
yury.norov@gmail.com, tglx@linutronix.de,
Joshua Baker <jobaker@redhat.com>,
audralmitchel@gmail.com, arnd@arndb.de,
gregkh@linuxfoundation.org, rafael@kernel.org, tj@kernel.org,
lizefan@huawei.com, Qais Yousef <qais.yousef@arm.com>,
hannes@cmpxchg.org, Alexey Klimov <klimov.linux@gmail.com>
Subject: Re: [PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining
Date: Thu, 11 Feb 2021 14:09:39 +0000 [thread overview]
Message-ID: <CAFBcO+_zMa8kC0cHnjAK6axX=CEL7UvS31ak_Vxr2gBO-JnH0Q@mail.gmail.com> (raw)
In-Reply-To: <87eehvz6sx.fsf@oracle.com>
On Fri, Feb 5, 2021 at 12:41 AM Daniel Jordan
<daniel.m.jordan@oracle.com> wrote:
>
> Peter Zijlstra <peterz@infradead.org> writes:
[...]
> >> > One concequence of this is that you'll now get a bunch of notifications
> >> > across things like suspend/hybernate.
> >>
> >> The patch doesn't change the number of kobject_uevent()s. The
> >> userspace will get the same number of uevents as before the patch (at
> >> least if I can rely on my eyes).
> >
> > bringup_hibernate_cpu() didn't used to generate an event, it does now.
> > Same for bringup_nonboot_cpus().
>
> Both of those call cpu_up(), which only gets a cpuset_wait_for_hotplug()
> in this patch. No new events generated from that, right, it's just a
> wrapper for a flush_work()?
>
> > Also, looking again, you don't seem to be reinstating the OFFLINE event
> > you took out.
>
> It seems to be reinstated in cpuhp_smt_disable()?
Peter, what Daniel said.
cpuset_wait_for_hotplug() doesn't generate an event.
The offline event was moved below in the same function:
+
+ /* Tell user space about the state changes */
+ for_each_cpu(cpu, mask) {
+ dev = get_cpu_device(cpu);
+ kobject_uevent(&dev->kobj, KOBJ_OFFLINE);
+ }
+
+ free_cpumask_var(mask);
Daniel,
thanks for your comments. I'll update the patch and resend.
Best regards,
Alexey
next prev parent reply other threads:[~2021-02-11 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 1:01 [PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining Alexey Klimov
2021-02-04 9:46 ` Peter Zijlstra
2021-02-04 12:50 ` Alexey Klimov
2021-02-04 13:42 ` Peter Zijlstra
2021-02-05 0:39 ` Daniel Jordan
2021-02-11 14:09 ` Alexey Klimov [this message]
2021-02-05 11:22 ` Qais Yousef
2021-02-11 13:38 ` Alexey Klimov
2021-02-05 1:35 ` Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBcO+_zMa8kC0cHnjAK6axX=CEL7UvS31ak_Vxr2gBO-JnH0Q@mail.gmail.com' \
--to=aklimov@redhat.com \
--cc=arnd@arndb.de \
--cc=audralmitchel@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=daniel.m.jordan@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=jobaker@redhat.com \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).