From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, jbrunet@baylibre.com,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/6] clk: meson: g12a: Add support for G12B CPUB clocks
Date: Sat, 27 Apr 2019 22:20:52 +0200 [thread overview]
Message-ID: <CAFBinCBHDf8N7J5C7SkCF44k+-H686EYbK9zm6TOg_oUWJ+vTw@mail.gmail.com> (raw)
In-Reply-To: <20190423091503.10847-3-narmstrong@baylibre.com>
On Tue, Apr 23, 2019 at 11:15 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> This patch support for the specific Amlogic G12B clocks.
>
> G12B clock driver is very close, the main differences are :
> - the clock tree is duplicated for the both clusters, and the
> SYS_PLL are swapped between the clusters
> - G12A has additional clocks like for CSI an other components
>
> Here only the cpu clock tree is handled.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
while reviewing I used the public S922X datasheet from hardkernel to
verify the implementation.
I noticed that HHI_SYS_PLL_CNTL1 and HHI_SYS1_PLL_CNTL1 seem to have
a 19-bit fractional part for the sys_pll and sys1_pll clocks.
Neil, do you know more about the fractional parts on these clocks?
Regards
Martin
next prev parent reply other threads:[~2019-04-27 20:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 9:14 [PATCH v2 0/6] arm64: Add initial support for Odroid-N2 Neil Armstrong
2019-04-23 9:14 ` [PATCH v2 1/6] dt-bindings: clk: meson: add g12b periph clock controller bindings Neil Armstrong
2019-04-27 20:18 ` Martin Blumenstingl
2019-04-23 9:14 ` [PATCH v2 2/6] clk: meson: g12a: Add support for G12B CPUB clocks Neil Armstrong
2019-04-27 20:20 ` Martin Blumenstingl [this message]
2019-04-23 9:15 ` [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical Neil Armstrong
2019-04-23 18:25 ` Stephen Boyd
2019-04-23 9:15 ` [PATCH v2 4/6] dt-bindings: arm: amlogic: add G12B bindings Neil Armstrong
2019-04-27 20:22 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 5/6] dt-bindings: arm: amlogic: add Odroid-N2 binding Neil Armstrong
2019-04-27 20:23 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 6/6] arm64: dts: meson: Add minimal support for Odroid-N2 Neil Armstrong
2019-04-27 20:26 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCBHDf8N7J5C7SkCF44k+-H686EYbK9zm6TOg_oUWJ+vTw@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).