From: "Łukasz Majczak" <lma@semihalf.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: "N, Harshapriya" <harshapriya.n@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Jie Yang <yang.jie@linux.intel.com>,
Radoslaw Biernacki <rad@semihalf.com>,
Ross Zwisler <zwisler@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
"M R, Sathya Prakash" <sathya.prakash.m.r@intel.com>,
Bob Brandt <brndt@google.com>, Marcin Wojtas <mw@semihalf.com>,
Alex Levin <levinale@chromium.org>
Subject: Re: [PATCH v3] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function
Date: Thu, 2 Jul 2020 12:09:59 +0200 [thread overview]
Message-ID: <CAFJ_xboZp02M3XAzTXMyUJU50CZDNBnrd_oOnYBWxFfMpr=1pg@mail.gmail.com> (raw)
In-Reply-To: <b2236769-6957-dc41-21b2-aca238994b4b@linux.intel.com>
Hi,
I am also ok with Harsha patch. I have checked it on my Eve and it looks ok.
Best regards,
Lukasz
śr., 1 lip 2020 o 19:08 Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> napisał(a):
>
>
> >>> Tested and the following is something we can use without creating a new
> >> dailink.
> >>> struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
> >>> if (!strcmp(codec_dai->name, KBL_REALTEK_DMIC_CODEC_DAI)) {
> >>> if (params_channels(params) == 2 ||
> >> DMIC_CH(dmic_constraints) == 2)
> >>> channels->min = channels->max = 2;
> >>> else
> >>> channels->min = channels->max = 4;
> >>> } else {
> >>> rate->min = rate->max = 48000;
> >>> channels->min = channels->max = 2;
> >>> snd_mask_none(fmt);
> >>> snd_mask_set_format(fmt, pcm_fmt);
> >>> }
> >>>
> >>> Pierre, thoughts?
> >>
> >> thanks Harsha, that looks like what I had in mind, but my earlier question was
> >> why we deal with the rates and formats only in the last case?
> > The speaker codec supported only 16 bit. (Vendor mentioned)
> > For playback on this platform, only 48Khz was used.
>
> ok then, as long as Harsha and Lukasz are aligned I'm fine. Thanks!
>
next prev parent reply other threads:[~2020-07-02 10:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 16:25 [PATCH v3] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function Lukasz Majczak
2020-05-21 16:32 ` Pierre-Louis Bossart
2020-05-21 17:08 ` Łukasz Majczak
2020-05-21 17:17 ` Pierre-Louis Bossart
2020-05-21 17:30 ` Łukasz Majczak
2020-05-21 18:10 ` Pierre-Louis Bossart
2020-06-29 11:11 ` Łukasz Majczak
2020-06-29 16:51 ` N, Harshapriya
2020-06-29 18:19 ` Łukasz Majczak
2020-06-29 22:30 ` N, Harshapriya
2020-07-01 16:37 ` N, Harshapriya
2020-07-01 16:48 ` Pierre-Louis Bossart
2020-07-01 17:00 ` N, Harshapriya
2020-07-01 17:08 ` Pierre-Louis Bossart
2020-07-02 10:09 ` Łukasz Majczak [this message]
2020-07-03 12:16 ` [PATCH v4] ASoC: Intel: kbl_rt5663_rt5514_max98927: Fix kabylake_ssp_fixup function Lukasz Majczak
2020-07-06 15:41 ` Pierre-Louis Bossart
2020-07-07 8:34 ` [PATCH v5] " Lukasz Majczak
2020-07-07 15:47 ` Pierre-Louis Bossart
2020-07-16 15:00 ` N, Harshapriya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFJ_xboZp02M3XAzTXMyUJU50CZDNBnrd_oOnYBWxFfMpr=1pg@mail.gmail.com' \
--to=lma@semihalf.com \
--cc=alsa-devel@alsa-project.org \
--cc=brndt@google.com \
--cc=harshapriya.n@intel.com \
--cc=levinale@chromium.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rad@semihalf.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=yang.jie@linux.intel.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).