From: Brendan Higgins <brendanhiggins@google.com>
To: Ignat Korchagin <ignat@cloudflare.com>
Cc: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
linux-um <linux-um@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-team@cloudflare.com
Subject: Re: [PATCH v2 0/3] um: allow static linking for non-glibc libc implementations
Date: Wed, 15 Jul 2020 01:36:49 -0700 [thread overview]
Message-ID: <CAFd5g44QK2L+Zkri9=mTFoLXTqdjORn-QATPomiKXkgZfA+wqw@mail.gmail.com> (raw)
In-Reply-To: <20200704085213.444645-1-ignat@cloudflare.com>
On Sat, Jul 4, 2020 at 1:52 AM Ignat Korchagin <ignat@cloudflare.com> wrote:
>
> This is a continuation of [1]. Since I was able to produce a working UML binary
> with UML_NET_VECTOR linked with musl with the changes included in the patches
> here. I was compiling on Arch Linux, so hopefully all the latest versions of
> the compiler, libraries and binutils.
>
> I also tested allyesconfig with both musl and glibc. The compilation succeeds
> with both, however both binaries (glibc one being dynamically linked) segfault
> on start. This is probably of some incompatible config option/module being
> included and not related to musl/glibc.
>
> [1]: https://patchwork.ozlabs.org/project/linux-um/patch/20200624212319.403689-1-ignat@cloudflare.com/
>
> Ignat Korchagin (3):
> um/kconfig: introduce CC_CAN_LINK_STATIC_NO_RUNTIME_DEPS
> um: some fixes to build UML with musl
> um: allow static linking for non-glibc implementations
>
> arch/um/Kconfig | 2 +-
> arch/um/drivers/Kconfig | 3 ---
> arch/um/drivers/daemon_user.c | 1 +
> arch/um/drivers/pcap_user.c | 12 ++++++------
> arch/um/drivers/slip_user.c | 2 +-
> arch/um/drivers/vector_user.c | 4 +---
> arch/um/os-Linux/util.c | 2 +-
> arch/x86/um/user-offsets.c | 2 +-
> init/Kconfig | 6 ++++++
> scripts/cc-can-link.sh | 5 +++--
> 10 files changed, 21 insertions(+), 18 deletions(-)
Sorry for taking so long to get to this. I saw this last week or
whenever and then forgot, saw the comments yesterday and remembered.
Looks pretty good overall. I will put my reviewed-by on each
individual patch. Nevertheless, I tested them all together, so being
lazy:
Tested-by: Brendan Higgins <brendanhiggins@google.com>
prev parent reply other threads:[~2020-07-15 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 8:52 [PATCH v2 0/3] um: allow static linking for non-glibc libc implementations Ignat Korchagin
2020-07-04 8:52 ` [PATCH v2 1/3] um/kconfig: introduce CC_CAN_LINK_STATIC_NO_RUNTIME_DEPS Ignat Korchagin
2020-07-15 8:38 ` Brendan Higgins
2020-07-04 8:52 ` [PATCH v2 2/3] um: some fixes to build UML with musl Ignat Korchagin
2020-07-14 8:40 ` Anton Ivanov
2020-07-14 10:23 ` Ignat Korchagin
2020-07-14 10:43 ` Anton Ivanov
2020-07-14 16:02 ` Johannes Berg
2020-07-15 8:47 ` Brendan Higgins
2020-07-04 8:52 ` [PATCH v2 3/3] um: allow static linking for non-glibc implementations Ignat Korchagin
2020-07-15 8:44 ` Brendan Higgins
2020-07-15 9:30 ` Ignat Korchagin
2020-07-15 8:36 ` Brendan Higgins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g44QK2L+Zkri9=mTFoLXTqdjORn-QATPomiKXkgZfA+wqw@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ignat@cloudflare.com \
--cc=jdike@addtoit.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).