From: Souptick Joarder <jrdr.linux@gmail.com>
To: FlorianSchandinat@gmx.de, b.zolnierkie@samsung.com
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev:via: Remove dead code
Date: Sun, 18 Aug 2019 22:29:38 +0530 [thread overview]
Message-ID: <CAFqt6zYrX-5d8yYVwesYBPWQZK4iXPPv=2w7dqBtHvF9c1WJHA@mail.gmail.com> (raw)
In-Reply-To: <CAFqt6zYsA_0YpZcZ8+LrMEjeWDJ5mwUDJNvqOW1H4ewgKbp+aQ@mail.gmail.com>
On Mon, Aug 12, 2019 at 5:37 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> On Wed, Aug 7, 2019 at 2:11 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >
> > On Wed, Jul 31, 2019 at 12:59 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> > >
> > > This is dead code since 3.15. If there is no plan to use
> > > it further, this can be removed forever.
> > >
> >
> > Any comment on this patch ?
>
> Any comment on this patch ?
If no comment can we get this in queue for 5.4 ?
>
> >
> > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > > ---
> > > drivers/video/fbdev/via/via-core.c | 43 --------------------------------------
> > > 1 file changed, 43 deletions(-)
> > >
> > > diff --git a/drivers/video/fbdev/via/via-core.c b/drivers/video/fbdev/via/via-core.c
> > > index e2b2062..ffa2ca2 100644
> > > --- a/drivers/video/fbdev/via/via-core.c
> > > +++ b/drivers/video/fbdev/via/via-core.c
> > > @@ -221,49 +221,6 @@ void viafb_release_dma(void)
> > > }
> > > EXPORT_SYMBOL_GPL(viafb_release_dma);
> > >
> > > -
> > > -#if 0
> > > -/*
> > > - * Copy a single buffer from FB memory, synchronously. This code works
> > > - * but is not currently used.
> > > - */
> > > -void viafb_dma_copy_out(unsigned int offset, dma_addr_t paddr, int len)
> > > -{
> > > - unsigned long flags;
> > > - int csr;
> > > -
> > > - mutex_lock(&viafb_dma_lock);
> > > - init_completion(&viafb_dma_completion);
> > > - /*
> > > - * Program the controller.
> > > - */
> > > - spin_lock_irqsave(&global_dev.reg_lock, flags);
> > > - viafb_mmio_write(VDMA_CSR0, VDMA_C_ENABLE|VDMA_C_DONE);
> > > - /* Enable ints; must happen after CSR0 write! */
> > > - viafb_mmio_write(VDMA_MR0, VDMA_MR_TDIE);
> > > - viafb_mmio_write(VDMA_MARL0, (int) (paddr & 0xfffffff0));
> > > - viafb_mmio_write(VDMA_MARH0, (int) ((paddr >> 28) & 0xfff));
> > > - /* Data sheet suggests DAR0 should be <<4, but it lies */
> > > - viafb_mmio_write(VDMA_DAR0, offset);
> > > - viafb_mmio_write(VDMA_DQWCR0, len >> 4);
> > > - viafb_mmio_write(VDMA_TMR0, 0);
> > > - viafb_mmio_write(VDMA_DPRL0, 0);
> > > - viafb_mmio_write(VDMA_DPRH0, 0);
> > > - viafb_mmio_write(VDMA_PMR0, 0);
> > > - csr = viafb_mmio_read(VDMA_CSR0);
> > > - viafb_mmio_write(VDMA_CSR0, VDMA_C_ENABLE|VDMA_C_START);
> > > - spin_unlock_irqrestore(&global_dev.reg_lock, flags);
> > > - /*
> > > - * Now we just wait until the interrupt handler says
> > > - * we're done.
> > > - */
> > > - wait_for_completion_interruptible(&viafb_dma_completion);
> > > - viafb_mmio_write(VDMA_MR0, 0); /* Reset int enable */
> > > - mutex_unlock(&viafb_dma_lock);
> > > -}
> > > -EXPORT_SYMBOL_GPL(viafb_dma_copy_out);
> > > -#endif
> > > -
> > > /*
> > > * Do a scatter/gather DMA copy from FB memory. You must have done
> > > * a successful call to viafb_request_dma() first.
> > > --
> > > 1.9.1
> > >
next prev parent reply other threads:[~2019-08-18 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 19:33 [PATCH] video: fbdev:via: Remove dead code Souptick Joarder
2019-08-07 8:41 ` Souptick Joarder
2019-08-12 12:07 ` Souptick Joarder
2019-08-18 16:59 ` Souptick Joarder [this message]
2019-08-19 14:05 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqt6zYrX-5d8yYVwesYBPWQZK4iXPPv=2w7dqBtHvF9c1WJHA@mail.gmail.com' \
--to=jrdr.linux@gmail.com \
--cc=FlorianSchandinat@gmx.de \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).