From: Souptick Joarder <jrdr.linux@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Robin van der Gracht <robin@protonic.nl>,
linux-kernel <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()
Date: Fri, 24 May 2019 11:40:43 +0530 [thread overview]
Message-ID: <CAFqt6zaAT5buz4VGzNkqKAH+r=usEU+fyK5EhgUP42Jfdy-rOw@mail.gmail.com> (raw)
In-Reply-To: <CANiq72nubJ6KHXROuDHV8Ap6MJQx6SDKUJCxYuN1_YDy=A_ELw@mail.gmail.com>
On Thu, May 23, 2019 at 6:53 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Mon, May 20, 2019 at 5:26 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >
> > While using mmap, the incorrect value of length and vm_pgoff are
> > ignored and this driver go ahead with mapping fbdev.buffer
> > to user vma.
>
> Typos: values*, goes* (same for the other patch)
Ok, will add it into v2.
>
> > Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
> > "fix" these drivers to behave according to the normal vm_pgoff
> > offsetting simply by removing the _zero suffix on the function name
> > and if that causes regressions, it gives us an easy way to revert.
>
> Would it be possible to add a "Link:" to where these new functions are
> discussed/used (maybe a lore.kernel.org link?)?
This might be helpful.
https://lkml.org/lkml/2018/12/24/204
>
> Thanks for the patch!
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2019-05-24 6:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 15:30 [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero() Souptick Joarder
2019-05-21 6:55 ` Robin van der Gracht
2019-05-23 8:18 ` Souptick Joarder
2019-05-23 12:58 ` Miguel Ojeda
2019-05-24 4:22 ` Miguel Ojeda
2019-05-24 6:07 ` Souptick Joarder
2019-05-28 19:03 ` Miguel Ojeda
2019-05-23 13:23 ` Miguel Ojeda
2019-05-24 6:10 ` Souptick Joarder [this message]
2019-05-26 16:11 Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqt6zaAT5buz4VGzNkqKAH+r=usEU+fyK5EhgUP42Jfdy-rOw@mail.gmail.com' \
--to=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=robin@protonic.nl \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).