From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E4F5C433F5 for ; Thu, 30 Sep 2021 19:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1027460C51 for ; Thu, 30 Sep 2021 19:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347291AbhI3TvI (ORCPT ); Thu, 30 Sep 2021 15:51:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229777AbhI3TvA (ORCPT ); Thu, 30 Sep 2021 15:51:00 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81E1AC06176C for ; Thu, 30 Sep 2021 12:49:15 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id 71so15777713ybe.6 for ; Thu, 30 Sep 2021 12:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qzu64fXHTiIcfDbo11y5nmqEplOgcWDPv9SREtrsAds=; b=Bb62IHSQDymweZCjp9xCrijJ4lA8x9M279DwXdVGqH/5uAqnookw/HiEaQlaS5zWqU 9KGcmVWArgai7IWvkHgaVbOJP6ugo6RiOI7h5W4m66/auYzQMFZBfhqxotRbpU8kiRzS PZpSxywFF1bA4enUzOcab2PVSVcafmV3BKdv/+cJCvBaH6GBJzbxROInp0b6E7+hWhz9 Ul0ZNkN01tBQkGdA9zJk9MLl8igAvDL+GZQi+qXIz5RzsiXi6c05uExo/xXTfJCOTaNW BP6luiLNrOScu1xZBasjy9zw4hyUtdM+E14rR5GhzRfXe7+i8ZwqAw15pTxYAg6uKmaP BawQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qzu64fXHTiIcfDbo11y5nmqEplOgcWDPv9SREtrsAds=; b=BMSSZzTD0YIORYO9zHASMC/kIBFdKLoFUk00u++Hm+vDrKL+QpcVVK2GK0XDnXcbXT bCwENYH/P7xe0Wqmlvsb4kTBH+1Up6K+Zgolj9t5GalrCX8O1dBfTTkhAzeI23pdSwHi ow6qB6VUA+EhO8tVNqa0Nia8VjCCgeSjlrMIvbcvZhAeArMArcPCy01N7JMB3bu+FdMr 7PV1hQVsk/LW/BM3ZjXYnCS4E2EdvPa73mS+aL7QwJHDVjs7vCo+Q1gWsR8PUAVaPyJe RL23jhWDlvj6ojc5y8d4kZ7lIvvo+RXLSWifdRuL2109ynLhQebT4/HLqqe0opx3a7Ps ymdw== X-Gm-Message-State: AOAM532MVpCSzPEe9XGrCfn+tH5RS/wZ7kqdnV7Id0LTnVlwuNU3RjCU nGOmu68d0bRwqkqAELIZBBiDGFupDlhcwAW2fnkkQA== X-Google-Smtp-Source: ABdhPJy+W7Tlus6n8v/jVtsLypB52CV1qGme2IbGkCZFgbZ1vtZMJQTdf96zuBomuacwcNbKiYAd8eQ34FMvbgF1v1g= X-Received: by 2002:a25:db91:: with SMTP id g139mr1183581ybf.391.1633031354608; Thu, 30 Sep 2021 12:49:14 -0700 (PDT) MIME-Version: 1.0 References: <20210831231804.zozyenear45ljemd@skbuf> <20210930134343.ztq3hgianm34dvqb@skbuf> In-Reply-To: From: Saravana Kannan Date: Thu, 30 Sep 2021 12:48:38 -0700 Message-ID: Subject: Re: [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT To: Andrew Lunn Cc: Vladimir Oltean , Greg Kroah-Hartman , "Rafael J. Wysocki" , Linus Walleij , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Len Brown , Alvin Sipraga , kernel-team@android.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 12:38 PM Andrew Lunn wrote: > > > Btw, do we have non-DSA networking devices where fw_devlink=on > > delaying PHY probes is causing an issue? > > I don't know if issues have been reported, but the realtek driver has > had problems in the past when the generic driver is used. Take a look > at r8169_mdio_register(), it does something similar to DSA. Does it have the issue of having the PHY as its child too and then depending on it to bind to a driver? I can't tell because I didn't know how to find that info for a PCI device. > > What is going to make things interesting is that phy_attach_direct() > is called in two different contexts. During the MAC drivers probe, it > is O.K. to return EPROBE_DEFER, and let the MAC driver try again > later, if we know there is a specific PHY driver for it. But when > called during the MAC drivers open() op, -EPROBE_DEFER is not > allowed. What to do then is an interesting question. Yeah, basically before doing an open() it'll have to call an API to say "just bind with whatever you got". Or something along those lines. I already know how to get that to work. I'll send some RFC soonish (I hope). -Saravana