From: Saravana Kannan <saravanak@google.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: maz@kernel.org, tglx@linutronix.de, jbrunet@baylibre.com,
khilman@baylibre.com, lee.jones@linaro.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module
Date: Thu, 2 Sep 2021 10:00:44 -0700 [thread overview]
Message-ID: <CAGETcx9KYWmmSYjXGPW6awmVYcKr6sdmxhc_tP=hf149=8Pm6A@mail.gmail.com> (raw)
In-Reply-To: <20210902134914.176986-2-narmstrong@baylibre.com>
On Thu, Sep 2, 2021 at 6:49 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> In order to reduce the kernel Image size on multi-platform distributions,
> make it possible to build the Amlogic GPIO IRQ controller as a module
> by switching it to a platform driver.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/irqchip/Kconfig | 5 +++--
> drivers/irqchip/irq-meson-gpio.c | 15 +++++++++------
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 4d5924e9f766..2aba485025fd 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -400,8 +400,9 @@ config IRQ_UNIPHIER_AIDET
> Support for the UniPhier AIDET (ARM Interrupt Detector).
>
> config MESON_IRQ_GPIO
> - bool "Meson GPIO Interrupt Multiplexer"
> - depends on ARCH_MESON
> + tristate "Meson GPIO Interrupt Multiplexer"
> + depends on ARCH_MESON || COMPILE_TEST
> + default ARCH_MESON
> select IRQ_DOMAIN_HIERARCHY
> help
> Support Meson SoC Family GPIO Interrupt Multiplexer
> diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c
> index e50676ce2ec8..d90ff0b92480 100644
> --- a/drivers/irqchip/irq-meson-gpio.c
> +++ b/drivers/irqchip/irq-meson-gpio.c
> @@ -436,8 +436,7 @@ static const struct irq_domain_ops meson_gpio_irq_domain_ops = {
> .translate = meson_gpio_irq_domain_translate,
> };
>
> -static int __init meson_gpio_irq_parse_dt(struct device_node *node,
> - struct meson_gpio_irq_controller *ctl)
> +static int meson_gpio_irq_parse_dt(struct device_node *node, struct meson_gpio_irq_controller *ctl)
> {
> const struct of_device_id *match;
> int ret;
> @@ -463,8 +462,7 @@ static int __init meson_gpio_irq_parse_dt(struct device_node *node,
> return 0;
> }
>
> -static int __init meson_gpio_irq_of_init(struct device_node *node,
> - struct device_node *parent)
> +static int meson_gpio_irq_of_init(struct device_node *node, struct device_node *parent)
> {
> struct irq_domain *domain, *parent_domain;
> struct meson_gpio_irq_controller *ctl;
> @@ -521,5 +519,10 @@ static int __init meson_gpio_irq_of_init(struct device_node *node,
> return ret;
> }
>
> -IRQCHIP_DECLARE(meson_gpio_intc, "amlogic,meson-gpio-intc",
> - meson_gpio_irq_of_init);
> +IRQCHIP_PLATFORM_DRIVER_BEGIN(meson_gpio_intc)
> +IRQCHIP_MATCH("amlogic,meson-gpio-intc", meson_gpio_irq_of_init)
> +IRQCHIP_PLATFORM_DRIVER_END(meson_gpio_intc)
> +
> +MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre.com>");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:meson-gpio-intc");
> --
Acked-by: Saravana Kannan <saravanak@google.com>
Marc, my mdio-mux patches have landed.
-Saravana
next prev parent reply other threads:[~2021-09-02 17:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 13:49 [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Neil Armstrong
2021-09-02 13:49 ` [PATCH 1/2] irqchip: " Neil Armstrong
2021-09-02 17:00 ` Saravana Kannan [this message]
2021-09-28 10:45 ` Lee Jones
2021-09-28 23:27 ` Kevin Hilman
2021-10-20 18:47 ` [irqchip: irq/irqchip-next] irqchip/meson-gpio: Make " irqchip-bot for Neil Armstrong
2021-09-02 13:49 ` [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection Neil Armstrong
2021-09-28 23:28 ` Kevin Hilman
2021-10-20 18:47 ` [irqchip: irq/irqchip-next] " irqchip-bot for Neil Armstrong
-- strict thread matches above, loose matches on Subject: below --
2020-10-20 7:25 [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Neil Armstrong
2020-10-20 7:25 ` [PATCH 1/2] irqchip: " Neil Armstrong
2020-10-20 18:23 ` Kevin Hilman
[not found] ` <CAF2Aj3g6c8FEZb3e1by6sd8LpKLaeN5hsKrrQkZUvh8hosiW9A@mail.gmail.com>
2021-05-24 10:11 ` Marc Zyngier
2021-05-25 16:17 ` Kevin Hilman
2021-05-25 16:30 ` Lee Jones
2021-06-14 22:30 ` Kevin Hilman
2021-07-13 9:05 ` Lee Jones
2021-08-03 9:44 ` Marc Zyngier
2021-08-03 9:51 ` Marc Zyngier
2021-08-04 2:11 ` Saravana Kannan
2021-08-03 9:51 ` Neil Armstrong
2021-08-04 1:36 ` Saravana Kannan
2021-08-04 8:50 ` Marc Zyngier
2021-08-04 18:20 ` Saravana Kannan
2021-08-04 21:47 ` Saravana Kannan
2021-08-05 6:31 ` Neil Armstrong
2021-08-06 23:55 ` Saravana Kannan
2021-08-05 7:57 ` Lee Jones
2021-08-16 12:47 ` Lee Jones
2021-08-16 20:27 ` Saravana Kannan
2021-08-16 20:46 ` Andrew Lunn
2021-08-16 21:02 ` Saravana Kannan
2021-08-16 21:18 ` Andrew Lunn
2021-08-17 7:24 ` Lee Jones
2021-08-17 18:12 ` Saravana Kannan
2021-08-18 11:19 ` Marc Zyngier
2021-09-02 9:28 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGETcx9KYWmmSYjXGPW6awmVYcKr6sdmxhc_tP=hf149=8Pm6A@mail.gmail.com' \
--to=saravanak@google.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).