From: Vinay Simha <simhavcs@gmail.com>
To: Vinay Simha BN <simhavcs@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Archit Taneja <archit.taneja@gmail.com>,
Rob Clark <robdclark@gmail.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] drm/dsi: Implement dcs set/get display brightness
Date: Tue, 28 Jun 2016 21:29:04 +0530 [thread overview]
Message-ID: <CAGWqDJ5ube3SpCegcyPKVhHPDnf7QAmwV_3M3BepGTjx40HWMw@mail.gmail.com> (raw)
In-Reply-To: <1466402029-23252-1-git-send-email-simhavcs@gmail.com>
hi,
Any further comments or reviews?
On Mon, Jun 20, 2016 at 11:23 AM, Vinay Simha BN <simhavcs@gmail.com> wrote:
> Provide a small convenience wrapper that set/get the
> display brightness value
>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Archit Taneja <archit.taneja@gmail.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
> ---
> v1:
> *tested in nexus7 2nd gen.
>
> v2:
> * implemented jani review comments
> -functions name mapped accordingly
> -bl value increased from 0xff to 0xffff
> -backlight interface will be handled in panel driver,
> so it is moved from the mipi_dsi helper function
> ---
> drivers/gpu/drm/drm_mipi_dsi.c | 49 ++++++++++++++++++++++++++++++++++++++++++
> include/drm/drm_mipi_dsi.h | 4 ++++
> 2 files changed, 53 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
> index 49311fc..2c03784 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -1041,6 +1041,55 @@ int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format)
> }
> EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format);
>
> +/**
> + * mipi_dsi_dcs_get_display_brightness() - gets the current brightness value
> + * of the display
> + * @dsi: DSI peripheral device
> + * @brightness: brightness value
> + *
> + * Return: 0 on success or a negative error code on failure.
> + */
> +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
> + u16 *brightness)
> +{
> + ssize_t err;
> +
> + err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS,
> + brightness, sizeof(*brightness));
> + if (err < 0) {
> + if (err == 0)
> + err = -ENODATA;
> +
> + return err;
> + }
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(mipi_dsi_dcs_get_display_brightness);
> +
> +/**
> + * mipi_dsi_dcs_set_display_brightness() - sets the brightness value of
> + * the display
> + * @dsi: DSI peripheral device
> + * @brightness: brightness value
> + *
> + * Return: 0 on success or a negative error code on failure.
> + */
> +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi,
> + u16 brightness)
> +{
> + ssize_t err;
> + u8 bl_value[2] = { brightness & 0xff, brightness >> 8 };
> +
> + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS,
> + bl_value, sizeof(bl_value));
> + if (err < 0)
> + return err;
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(mipi_dsi_dcs_set_display_brightness);
> +
> static int mipi_dsi_drv_probe(struct device *dev)
> {
> struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver);
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index 72f5b15..4d77bb0 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -270,6 +270,10 @@ int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi);
> int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi,
> enum mipi_dsi_dcs_tear_mode mode);
> int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format);
> +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
> + u16 *brightness);
> +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi,
> + u16 brightness);
>
> /**
> * struct mipi_dsi_driver - DSI driver
> --
> 2.1.2
>
--
Regards,
Vinay Simha.B.N.
next prev parent reply other threads:[~2016-06-28 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 5:53 [PATCH v2 1/2] drm/dsi: Implement dcs set/get display brightness Vinay Simha BN
2016-06-20 5:53 ` [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Vinay Simha BN
2016-06-28 15:59 ` Vinay Simha
2016-07-03 22:52 ` Emil Velikov
2016-07-04 6:27 ` Vinay Simha
2016-07-06 17:16 ` Emil Velikov
2016-07-11 12:20 ` Thierry Reding
2016-07-11 12:31 ` Vinay Simha
2016-07-11 14:12 ` Emil Velikov
2016-06-28 15:59 ` Vinay Simha [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-17 18:23 [PATCH v2 1/2] drm/dsi: Implement dcs set/get display brightness Vinay Simha BN
2016-06-16 3:00 Vinay Simha BN
2016-06-13 10:25 Vinay Simha BN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWqDJ5ube3SpCegcyPKVhHPDnf7QAmwV_3M3BepGTjx40HWMw@mail.gmail.com \
--to=simhavcs@gmail.com \
--cc=airlied@linux.ie \
--cc=archit.taneja@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).