From: Kees Cook <keescook@chromium.org>
To: kbuild test robot <lkp@intel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh <linux-sh@vger.kernel.org>
Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Daniel Micay <danielmicay@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fortify: Avoid panic() in favor of BUG()
Date: Tue, 27 Jun 2017 12:16:12 -0700 [thread overview]
Message-ID: <CAGXu5jL5uDLDUfLtoyfCOpGByR=XLN5yGcePreCs7jN6NE=0Hw@mail.gmail.com> (raw)
In-Reply-To: <201706272333.FIsTGv3H%fengguang.wu@intel.com>
On Tue, Jun 27, 2017 at 8:52 AM, kbuild test robot <lkp@intel.com> wrote:
> Hi Kees,
>
> [auto build test WARNING on next-20170619]
> [cannot apply to linus/master linux/master v4.12-rc6 v4.12-rc5 v4.12-rc4 v4.12-rc7]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Kees-Cook/fortify-Avoid-panic-in-favor-of-BUG/20170627-230653
> config: sh-allyesconfig (attached as .config)
> compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=sh
>
> All warnings (new ones prefixed by >>):
>
> lib/string.c: In function 'fortify_panic':
>>> lib/string.c:986:1: warning: 'noreturn' function does return
> }
> ^
>
> vim +/noreturn +986 lib/string.c
>
> 94df2904 Rasmus Villemoes 2015-06-25 970 *
> 94df2904 Rasmus Villemoes 2015-06-25 971 * Returns pointer to the nul byte at the end of @s.
> 94df2904 Rasmus Villemoes 2015-06-25 972 */
> 94df2904 Rasmus Villemoes 2015-06-25 973 char *strreplace(char *s, char old, char new)
> 94df2904 Rasmus Villemoes 2015-06-25 974 {
> 94df2904 Rasmus Villemoes 2015-06-25 975 for (; *s; ++s)
> 94df2904 Rasmus Villemoes 2015-06-25 976 if (*s == old)
> 94df2904 Rasmus Villemoes 2015-06-25 977 *s = new;
> 94df2904 Rasmus Villemoes 2015-06-25 978 return s;
> 94df2904 Rasmus Villemoes 2015-06-25 979 }
> 94df2904 Rasmus Villemoes 2015-06-25 980 EXPORT_SYMBOL(strreplace);
> b90d6eba Daniel Micay 2017-06-06 981
> b90d6eba Daniel Micay 2017-06-06 982 void fortify_panic(const char *name)
> b90d6eba Daniel Micay 2017-06-06 983 {
> 8a94b337 Kees Cook 2017-06-26 984 pr_emerg("detected buffer overflow in %s\n", name);
> 8a94b337 Kees Cook 2017-06-26 985 BUG();
> b90d6eba Daniel Micay 2017-06-06 @986 }
> b90d6eba Daniel Micay 2017-06-06 987 EXPORT_SYMBOL(fortify_panic);
This implies that the sh arch doesn't correctly mark their BUG
implementation as not returning... I'll send a patch.
-Kees
--
Kees Cook
Pixel Security
prev parent reply other threads:[~2017-06-27 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 23:51 [PATCH] fortify: Avoid panic() in favor of BUG() Kees Cook
2017-06-27 15:52 ` kbuild test robot
2017-06-27 19:16 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jL5uDLDUfLtoyfCOpGByR=XLN5yGcePreCs7jN6NE=0Hw@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=dalias@libc.org \
--cc=danielmicay@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mchehab@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).