From: Maarten Maathuis <madman2003@gmail.com>
To: Dmitry Cherkasov <dcherkassov@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
Dmitry Cherkasov <Dmitrii.Cherkasov@amd.com>
Subject: Re: [PATCH 2/2] Add 2-level GPUVM pagetables support to radeon driver. v2
Date: Sat, 15 Sep 2012 14:56:49 +0200 [thread overview]
Message-ID: <CAGZ4FESdyqFbMxJir=QdRURU1J-03NLOr+XT-TzqHFf+S=J8WQ@mail.gmail.com> (raw)
In-Reply-To: <1347644982-17386-2-git-send-email-Dmitrii.Cherkasov@amd.com>
On Fri, Sep 14, 2012 at 7:49 PM, Dmitry Cherkasov <dcherkassov@gmail.com> wrote:
> +#define RADEON_PT_OFFSET(_rdev) \
> + (RADEON_GPU_PAGE_ALIGN(RADEON_TOTAL_PDE_COUNT(rdev) * RADEON_PDE_SIZE))
Shouldn't that be _rdev too?
Also a few lines above that you use rdev instead of _rdev.
I didn't check the whole thing, just noticed that when i was staring
at it for no reason :-)
--
Far away from the primal instinct, the song seems to fade away, the
river get wider between your thoughts and the things we do and say.
next prev parent reply other threads:[~2012-09-15 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 17:49 [PATCH 1/2] drm/radeon: refactor set_page chipset interface v2 Dmitry Cherkasov
2012-09-14 17:49 ` [PATCH 2/2] Add 2-level GPUVM pagetables support to radeon driver. v2 Dmitry Cherkasov
2012-09-15 12:56 ` Maarten Maathuis [this message]
2012-09-15 14:58 ` Christian König
2012-09-15 13:22 ` [PATCH 1/2] drm/radeon: refactor set_page chipset interface v2 Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ4FESdyqFbMxJir=QdRURU1J-03NLOr+XT-TzqHFf+S=J8WQ@mail.gmail.com' \
--to=madman2003@gmail.com \
--cc=Dmitrii.Cherkasov@amd.com \
--cc=alexander.deucher@amd.com \
--cc=dcherkassov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).