From: Chen-Yu Tsai <wens@csie.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Thierry Reding <thierry.reding@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-pwm@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH 2/6] pwm: sun4i: Add a quirk for reset line
Date: Mon, 29 Jul 2019 14:43:23 +0800 [thread overview]
Message-ID: <CAGb2v65KOpivHQNkg+R2=D=ejCJYnPdVcyHJZW-GJCR8j0Yk0g@mail.gmail.com> (raw)
In-Reply-To: <20190729063630.rn325whatfnc3m7n@pengutronix.de>
On Mon, Jul 29, 2019 at 2:36 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Cc += reset framework maintainer
>
> Hello Jernej,
>
> On Fri, Jul 26, 2019 at 08:40:41PM +0200, Jernej Skrabec wrote:
> > H6 PWM core needs deasserted reset line in order to work.
> >
> > Add a quirk for it.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> > drivers/pwm/pwm-sun4i.c | 27 +++++++++++++++++++++++++--
> > 1 file changed, 25 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
> > index de78c824bbfd..1b7be8fbde86 100644
> > --- a/drivers/pwm/pwm-sun4i.c
> > +++ b/drivers/pwm/pwm-sun4i.c
> > @@ -16,6 +16,7 @@
> > #include <linux/of_device.h>
> > #include <linux/platform_device.h>
> > #include <linux/pwm.h>
> > +#include <linux/reset.h>
> > #include <linux/slab.h>
> > #include <linux/spinlock.h>
> > #include <linux/time.h>
> > @@ -72,12 +73,14 @@ static const u32 prescaler_table[] = {
> >
> > struct sun4i_pwm_data {
> > bool has_prescaler_bypass;
> > + bool has_reset;
> > unsigned int npwm;
> > };
> >
> > struct sun4i_pwm_chip {
> > struct pwm_chip chip;
> > struct clk *clk;
> > + struct reset_control *rst;
> > void __iomem *base;
> > spinlock_t ctrl_lock;
> > const struct sun4i_pwm_data *data;
> > @@ -371,6 +374,14 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
> > if (IS_ERR(pwm->clk))
> > return PTR_ERR(pwm->clk);
> >
> > + if (pwm->data->has_reset) {
> > + pwm->rst = devm_reset_control_get(&pdev->dev, NULL);
> > + if (IS_ERR(pwm->rst))
> > + return PTR_ERR(pwm->rst);
> > +
> > + reset_control_deassert(pwm->rst);
> > + }
> > +
>
> I wonder why there is a need to track if a given chip needs a reset
> line. I'd just use devm_reset_control_get_optional() and drop the
> .has_reset member in struct sun4i_pwm_data.
Because it's not optional for this platform, i.e. it won't work if
the reset control (or clk, in the next patch) is somehow missing from
the device tree.
ChenYu
> > pwm->chip.dev = &pdev->dev;
> > pwm->chip.ops = &sun4i_pwm_ops;
> > pwm->chip.base = -1;
> > @@ -383,19 +394,31 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
> > ret = pwmchip_add(&pwm->chip);
> > if (ret < 0) {
> > dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);
> > - return ret;
> > + goto err_pwm_add;
> > }
> >
> > platform_set_drvdata(pdev, pwm);
> >
> > return 0;
> > +
> > +err_pwm_add:
> > + reset_control_assert(pwm->rst);
> > +
> > + return ret;
> > }
> >
> > static int sun4i_pwm_remove(struct platform_device *pdev)
> > {
> > struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev);
> > + int ret;
> > +
> > + ret = pwmchip_remove(&pwm->chip);
> > + if (ret)
> > + return ret;
> >
> > - return pwmchip_remove(&pwm->chip);
> > + reset_control_assert(pwm->rst);
> > +
> > + return 0;
> > }
> >
> > static struct platform_driver sun4i_pwm_driver = {
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-07-29 6:43 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 18:40 [PATCH 0/6] pwm: sun4i: Add support for Allwinner H6 Jernej Skrabec
2019-07-26 18:40 ` [PATCH 1/6] dt-bindings: pwm: allwinner: Add H6 PWM description Jernej Skrabec
2019-07-27 10:42 ` Maxime Ripard
2019-07-26 18:40 ` [PATCH 2/6] pwm: sun4i: Add a quirk for reset line Jernej Skrabec
2019-07-27 10:42 ` Maxime Ripard
2019-07-29 6:36 ` Uwe Kleine-König
2019-07-29 6:43 ` Chen-Yu Tsai [this message]
2019-07-29 7:12 ` Uwe Kleine-König
2019-07-29 10:18 ` Philipp Zabel
2019-07-29 16:37 ` Maxime Ripard
2019-07-29 18:20 ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 3/6] pwm: sun4i: Add a quirk for bus clock Jernej Skrabec
2019-07-27 10:46 ` Maxime Ripard
2019-07-27 14:15 ` Jernej Škrabec
2019-07-27 14:27 ` Chen-Yu Tsai
2019-07-29 6:38 ` Uwe Kleine-König
2019-07-29 15:48 ` Jernej Škrabec
2019-07-29 16:14 ` Uwe Kleine-König
2019-07-29 16:45 ` Maxime Ripard
2019-07-29 19:04 ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 4/6] pwm: sun4i: Add support for H6 PWM Jernej Skrabec
2019-07-29 6:40 ` Uwe Kleine-König
2019-07-29 15:55 ` Jernej Škrabec
2019-07-29 16:07 ` Uwe Kleine-König
2019-07-29 16:09 ` [linux-sunxi] " Chen-Yu Tsai
2019-07-29 16:24 ` Uwe Kleine-König
2019-07-29 16:40 ` Jernej Škrabec
2019-07-29 18:40 ` Uwe Kleine-König
2019-07-29 18:46 ` Jernej Škrabec
2019-07-29 18:51 ` Uwe Kleine-König
2019-07-29 22:04 ` Jernej Škrabec
2019-07-30 8:09 ` Uwe Kleine-König
2019-07-30 8:32 ` Chen-Yu Tsai
2019-07-30 17:06 ` Maxime Ripard
2019-07-31 6:52 ` Uwe Kleine-König
2019-08-12 9:56 ` Maxime Ripard
2019-08-12 10:47 ` Uwe Kleine-König
2019-08-12 10:51 ` Jernej Škrabec
2019-07-26 18:40 ` [PATCH 5/6] pwm: sun4i: Add support to output source clock directly Jernej Skrabec
2019-07-27 10:50 ` Maxime Ripard
2019-07-27 14:28 ` Jernej Škrabec
2019-07-27 14:54 ` [linux-sunxi] " Chen-Yu Tsai
2019-07-29 7:06 ` Uwe Kleine-König
2019-07-29 16:16 ` Jernej Škrabec
2019-07-29 16:29 ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 6/6] arm64: dts: allwinner: h6: Add PWM node Jernej Skrabec
2019-07-27 10:51 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v65KOpivHQNkg+R2=D=ejCJYnPdVcyHJZW-GJCR8j0Yk0g@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).