From: Chen-Yu Tsai <wens@csie.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.
Date: Wed, 31 Aug 2016 15:43:39 +0800 [thread overview]
Message-ID: <CAGb2v67YGiZEzBezub5HcEBZ5689uF1yQYj2xJkbVdHyEpOm5Q@mail.gmail.com> (raw)
In-Reply-To: <20160831094044.1c3227d6@scratchpost.org>
On Wed, Aug 31, 2016 at 3:40 PM, Danny Milosavljevic
<dannym@scratchpost.org> wrote:
>> And what about microphone bias?
>
> Would this be OK?
>
> static int sun4i_codec_handle_mic_bias_event(struct snd_soc_dapm_widget *w,
> struct snd_kcontrol *k, int event)
> {
> struct sun4i_codec *scodec = snd_soc_card_get_drvdata(w->dapm->card);
> if (SND_SOC_DAPM_EVENT_ON(event))
> regmap_update_bits(scodec->regmap,
> SUN4I_CODEC_ADC_ACTL,
> BIT(SUN4I_CODEC_ADC_ACTL_VMICEN),
> BIT(SUN4I_CODEC_ADC_ACTL_VMICEN));
> else
> regmap_update_bits(scodec->regmap,
> SUN4I_CODEC_ADC_ACTL,
> BIT(SUN4I_CODEC_ADC_ACTL_VMICEN),
> 0);
> }
>
> static const struct snd_soc_dapm_widget sun4i_codec_codec_dapm_widgets[] = {
> ...
> SND_SOC_DAPM_MIC("Mic1", sun4i_codec_handle_mic_bias_event),
> SND_SOC_DAPM_MIC("Mic2", sun4i_codec_handle_mic_bias_event),
>
> Do I then remove
>
> SND_SOC_DAPM_SUPPLY("VMIC", SUN4I_CODEC_ADC_ACTL,
> SUN4I_CODEC_ADC_ACTL_VMICEN, 0, NULL, 0),
>
> completely? What about the routes?
My apologies. I didn't notice that VMIC was already in the driver.
In that your original patch did everything right.
ChenYu
next prev parent reply other threads:[~2016-08-31 7:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 5:44 [PATCH v9 0/2] sun4i-codec: Add Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
2016-08-30 5:44 ` [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Danny Milosavljevic
2016-08-31 3:22 ` Chen-Yu Tsai
2016-08-31 17:46 ` Maxime Ripard
2016-08-31 20:14 ` [linux-sunxi] " Danny Milosavljevic
2016-09-01 16:45 ` Maxime Ripard
2016-08-30 5:44 ` [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
2016-08-31 6:24 ` Chen-Yu Tsai
2016-08-31 7:17 ` Danny Milosavljevic
2016-08-31 7:46 ` Chen-Yu Tsai
2016-08-31 7:40 ` [linux-sunxi] " Danny Milosavljevic
2016-08-31 7:43 ` Chen-Yu Tsai [this message]
2016-08-31 7:49 ` Danny Milosavljevic
2016-08-31 7:55 ` Chen-Yu Tsai
2016-09-01 10:56 ` Danny Milosavljevic
2016-09-01 13:25 ` [linux-sunxi] " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v67YGiZEzBezub5HcEBZ5689uF1yQYj2xJkbVdHyEpOm5Q@mail.gmail.com \
--to=wens@csie.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dannym@scratchpost.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).