From: Sven Van Asbroeck <thesven73@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, svendev@arcx.com,
linux-kernel@vger.kernel.org, divagar.mohandass@intel.com,
brgl@bgdev.pl
Subject: Re: [PATCH 1/1] at24: Fix I²C device selection for runtime PM
Date: Fri, 1 Dec 2017 10:20:41 -0500 [thread overview]
Message-ID: <CAGngYiUktfXOU64Uo-O=01OWJrT8fQ7icxS6m4mQO+6UAkGUsA@mail.gmail.com> (raw)
In-Reply-To: <20171130223524.31716-1-sakari.ailus@linux.intel.com>
Thank you, it fixes the issue on the multi-address eeprom that I have access to.
Tested-by: Sven Van Asbroeck on a 24AA16/24LC16B <svendev@arcx.com>
One very minor remark:
+ struct device *dev = &at24->client[0]->dev;
It is sufficiently clear to others (and us a few months down the line)
why we are
using only client[0] for power management? Could it benefit from a separate
function with comments?
struct device *dev = get_pm_device(at24);
static struct device *get_pm_device(struct at24_data *at24)
{
/* explain why we use client[0] and not any of the dummies */
return &at24->client[0]->dev;
}
next prev parent reply other threads:[~2017-12-01 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 19:03 BUG: support for at24 multi-slave-address eeproms is broken Sven Van Asbroeck
2017-11-30 22:34 ` Sakari Ailus
2017-12-01 10:04 ` Bartosz Golaszewski
2017-11-30 22:35 ` [PATCH 1/1] at24: Fix I²C device selection for runtime PM Sakari Ailus
2017-12-01 15:20 ` Sven Van Asbroeck [this message]
2017-12-01 15:35 ` Sakari Ailus
2017-12-01 16:29 ` Bartosz Golaszewski
2017-12-01 17:59 ` Sven Van Asbroeck
2017-12-02 14:44 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGngYiUktfXOU64Uo-O=01OWJrT8fQ7icxS6m4mQO+6UAkGUsA@mail.gmail.com' \
--to=thesven73@gmail.com \
--cc=brgl@bgdev.pl \
--cc=divagar.mohandass@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=svendev@arcx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).