From: Sven Van Asbroeck <thesven73@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Sven Van Asbroeck" <svendev@arcx.com>,
robh+dt@kernel.org, "Linus Walleij" <linus.walleij@linaro.org>,
"Lee Jones" <lee.jones@linaro.org>,
mark.rutland@arm.com, "Andreas Färber" <afaerber@suse.de>,
treding@nvidia.com, "David Lechner" <david@lechnology.com>,
noralf@tronnes.org, johan@kernel.org,
"Michal Simek" <monstr@monstr.eu>,
michal.vokac@ysoft.com, gregkh@linuxfoundation.org,
john.garry@huawei.com, geert+renesas@glider.be,
robin.murphy@arm.com, paul.gortmaker@windriver.com,
sebastien.bourdelin@savoirfairelinux.com, icenowy@aosc.io,
"Stuart Yoder" <stuyoder@gmail.com>,
maxime.ripard@bootlin.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus
Date: Thu, 8 Nov 2018 10:47:20 -0500 [thread overview]
Message-ID: <CAGngYiXEsg-6MXK60s8gOq2d8LGq+USTk1FC3GYqy2TQheaxHg@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3DnKcRxL5dG_pvBVTngFh5eDL2JdEqZzgL0RXJy5dZGw@mail.gmail.com>
On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> It looks like you build your own object management here. Maybe
> use kobject, or at least kref instead of the refcount_t based
> low-level implementation?
Excellent point. I'll replace with krefs.
>
>
> I see this is called from the interrupt handler at the moment, which
> means you cannot call sleeping functions, but it also means that
> the timeout may never happen because the timer tick IRQ cannot
> get through. That means you may have to change the irq handler
> logic, e.g. to try this a few times but then defer to a bottom half
> if it fails for a long time.
Touche ! Yes, this is very likely a big problem.
What if I converted the interrupt handler into a threaded interrupt handler?
That would allow the timer tick to get through, correct?
Point taken about cpu_relax(), I will fix.
next prev parent reply other threads:[~2018-11-08 15:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 15:54 [PATCH anybus v3 0/6] Support HMS Profinet Card over Anybus thesven73
2018-11-04 15:54 ` [PATCH anybus v3 1/6] misc: support the Arcx anybus bridge thesven73
2018-11-05 21:20 ` Rob Herring
2018-11-05 21:50 ` Sven Van Asbroeck
2018-11-06 13:58 ` Rob Herring
2018-11-06 14:45 ` Sven Van Asbroeck
2018-11-06 18:30 ` Rob Herring
2018-11-06 20:05 ` Sven Van Asbroeck
2018-11-08 13:40 ` Arnd Bergmann
2018-11-04 15:54 ` [PATCH anybus v3 2/6] dt-bindings: Add vendor prefix for arcx / Archronix thesven73
2018-11-04 15:57 ` Andreas Färber
2018-11-05 20:44 ` Rob Herring
2018-11-04 15:54 ` [PATCH anybus v3 3/6] dt-bindings: anybus-bridge: document devicetree binding thesven73
2018-11-05 20:45 ` Rob Herring
2018-11-04 15:54 ` [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus thesven73
2018-11-08 14:07 ` Arnd Bergmann
2018-11-08 15:47 ` Sven Van Asbroeck [this message]
2018-11-08 16:54 ` Arnd Bergmann
2018-11-09 16:25 ` Sven Van Asbroeck
2018-11-09 21:03 ` Arnd Bergmann
2018-11-10 10:55 ` Geert Uytterhoeven
2018-11-12 16:23 ` Sven Van Asbroeck
2018-11-04 15:55 ` [PATCH anybus v3 5/6] dt-bindings: anybuss-host: document devicetree binding thesven73
2018-11-08 14:11 ` Arnd Bergmann
2018-11-08 14:21 ` Sven Van Asbroeck
2018-11-08 14:27 ` Arnd Bergmann
2018-11-12 18:05 ` Sven Van Asbroeck
2018-11-04 15:55 ` [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller thesven73
2018-11-08 14:20 ` Arnd Bergmann
2018-11-08 15:35 ` Sven Van Asbroeck
2018-11-08 16:52 ` Arnd Bergmann
2018-11-09 16:02 ` [PATCH anybus v3 0/6] Support HMS Profinet Card over Anybus Sven Van Asbroeck
2018-11-09 21:22 ` Arnd Bergmann
2018-11-09 21:46 ` Sven Van Asbroeck
2018-11-09 22:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGngYiXEsg-6MXK60s8gOq2d8LGq+USTk1FC3GYqy2TQheaxHg@mail.gmail.com \
--to=thesven73@gmail.com \
--cc=afaerber@suse.de \
--cc=arnd@arndb.de \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=icenowy@aosc.io \
--cc=johan@kernel.org \
--cc=john.garry@huawei.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=michal.vokac@ysoft.com \
--cc=monstr@monstr.eu \
--cc=noralf@tronnes.org \
--cc=paul.gortmaker@windriver.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sebastien.bourdelin@savoirfairelinux.com \
--cc=stuyoder@gmail.com \
--cc=svendev@arcx.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).