From: Matteo Croce <mcroce@redhat.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
salyzyn@android.com, pcc@google.com, 0x7f454c46@gmail.com,
linux@rasmusvillemoes.dk, sthotton@marvell.com,
andre.przywara@arm.com, Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH] arm64: vdso: Fix Makefile regression
Date: Mon, 29 Jul 2019 18:33:48 +0200 [thread overview]
Message-ID: <CAGnkfhw+=+50P=uaWsjZrtt_BuwJjXKZ_DSTjuJ8mzW4_kbu-w@mail.gmail.com> (raw)
In-Reply-To: <20190729125421.32482-1-vincenzo.frascino@arm.com>
On Mon, Jul 29, 2019 at 2:54 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> Using an old .config in combination with "make oldconfig" can cause
> an incorrect detection of the compat compiler:
>
> $ grep CROSS_COMPILE_COMPAT .config
> CONFIG_CROSS_COMPILE_COMPAT_VDSO=""
>
> $ make oldconfig && make
> arch/arm64/Makefile:58: gcc not found, check CROSS_COMPILE_COMPAT.
> Stop.
>
> Accordingly to the section 7.2 of the GNU Make manual "Syntax of
> Conditionals", "When the value results from complex expansions of
> variables and functions, expansions you would consider empty may
> actually contain whitespace characters and thus are not seen as
> empty. However, you can use the strip function to avoid interpreting
> whitespace as a non-empty value."
>
> Fix the issue adding strip to the CROSS_COMPILE_COMPAT string
> evaluation.
>
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> arch/arm64/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index bb1f1dbb34e8..61de992bbea3 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -52,7 +52,7 @@ ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y)
>
> ifeq ($(CONFIG_CC_IS_CLANG), y)
> $(warning CROSS_COMPILE_COMPAT is clang, the compat vDSO will not be built)
> - else ifeq ($(CROSS_COMPILE_COMPAT),)
> + else ifeq ($(strip $(CROSS_COMPILE_COMPAT)),)
> $(warning CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built)
> else ifeq ($(shell which $(CROSS_COMPILE_COMPAT)gcc 2> /dev/null),)
> $(error $(CROSS_COMPILE_COMPAT)gcc not found, check CROSS_COMPILE_COMPAT)
> --
> 2.22.0
>
Tested-by: Matteo Croce <mcroce@redhat.com>
--
Matteo Croce
per aspera ad upstream
next prev parent reply other threads:[~2019-07-29 16:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 20:08 build error Matteo Croce
2019-07-28 20:15 ` Bernd Petrovitsch
2019-07-28 20:28 ` Matteo Croce
2019-07-29 4:44 ` Bhaskar Chowdhury
2019-07-29 7:58 ` Matteo Croce
2019-07-29 9:50 ` Will Deacon
2019-07-29 10:08 ` Matteo Croce
2019-07-29 10:16 ` Vincenzo Frascino
2019-07-29 10:21 ` Matteo Croce
2019-07-29 10:25 ` Matteo Croce
2019-07-29 11:08 ` Vincenzo Frascino
2019-07-29 11:12 ` Matteo Croce
2019-07-29 11:18 ` Vincenzo Frascino
2019-07-29 11:26 ` Matteo Croce
2019-07-29 12:54 ` [PATCH] arm64: vdso: Fix Makefile regression Vincenzo Frascino
2019-07-29 16:33 ` Matteo Croce [this message]
2019-07-31 16:23 ` Will Deacon
2019-07-31 17:09 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGnkfhw+=+50P=uaWsjZrtt_BuwJjXKZ_DSTjuJ8mzW4_kbu-w@mail.gmail.com' \
--to=mcroce@redhat.com \
--cc=0x7f454c46@gmail.com \
--cc=andre.przywara@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@kernel.org \
--cc=pcc@google.com \
--cc=salyzyn@android.com \
--cc=sthotton@marvell.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).