From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AEC8C433DF for ; Wed, 20 May 2020 11:17:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B1F5207D3 for ; Wed, 20 May 2020 11:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b3I6Hev2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbgETLRN (ORCPT ); Wed, 20 May 2020 07:17:13 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:43041 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726510AbgETLRN (ORCPT ); Wed, 20 May 2020 07:17:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589973431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+3+XJ/Vfn9hEmmjKQHW1eZ3jCSPljvkuiuCcfSEsoMI=; b=b3I6Hev28oYJqY5zzSx1p9YR9qKDukc7FcGpHw59oMZpTHBX/YFTOvKTrlaNZdBJiBjdHf b889dFaeHmXjKzEkc7qkKzrKaycrg5vOUJbDCLNQ0KgIyAq/GG0on2MJ52OmJp8x4dc+j/ t8v8FBvw8Ug/K8mGgCPOh+8kfSsk1KA= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-205-FFhbhdDqMVmrQVmA81gxRw-1; Wed, 20 May 2020 07:17:02 -0400 X-MC-Unique: FFhbhdDqMVmrQVmA81gxRw-1 Received: by mail-ej1-f71.google.com with SMTP id s7so1232709eji.0 for ; Wed, 20 May 2020 04:17:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+3+XJ/Vfn9hEmmjKQHW1eZ3jCSPljvkuiuCcfSEsoMI=; b=P1aOpoRUCJu3jF4Q0YVtSrxC82yesLVHS4GtJL4loKNoJmSlxsNGj76dsDj764SzDh CadHoT0K1ufb7kYcXeUYo5+xMeRVEnA13hFDxCvQk/6md/uVW1dzmZrUoqiiRu8Mn/ZT DCUQoIpml7IFDnUZGhpLa9HHfBG6ggQyUmoJCNNmVD19kqBvGwZdm+VLSV+A8VeYlZ7D 8HUnF0B9fz73VDaQaNyEbGQwJ+TVF28u+IbdZ+dqaklYZlZ3gXjTZzsed2F6hwogfm8E y/CBbWmPFtNl1CXOdFZSGn/gRFToZA1k5YPyH8s/HrVywhKdVzqR08E7zZ1tbIFhTTfS M18Q== X-Gm-Message-State: AOAM530EY8mvYcy/6Y6DffGs1vBhtVPvPxgbKd3z+0eK6AC9jqknCabR xRvQDVAXdAWM/bovuSFhPWV8ig6fz5+gFqx6Bz6K6ry9Fzyz8HDHhbs7Em1VbjlRu1+lr8FFo0a 4zpD1isP1Sryv6hXQJkigGzex3b5NIQOY0rbySfBp X-Received: by 2002:aa7:dc49:: with SMTP id g9mr2772106edu.62.1589973421150; Wed, 20 May 2020 04:17:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9yaJKGnybcRqUxUy3GthqkOjqhNi4tj5jBm01HqNr4HhbfSnN0NrfDJG+uO9vI/xvh0Cix+t4RnN+OLDEWpE= X-Received: by 2002:aa7:dc49:: with SMTP id g9mr2772082edu.62.1589973420888; Wed, 20 May 2020 04:17:00 -0700 (PDT) MIME-Version: 1.0 References: <20200423170003.GT25745@shell.armlinux.org.uk> <20200509114518.GB1551@shell.armlinux.org.uk> <20200509195246.GJ1551@shell.armlinux.org.uk> <20200509202050.GK1551@shell.armlinux.org.uk> <20200519095330.GA1551@shell.armlinux.org.uk> <20200519190534.78bb8389@turbo.teknoraver.net> <20200520111043.GK1551@shell.armlinux.org.uk> In-Reply-To: <20200520111043.GK1551@shell.armlinux.org.uk> From: Matteo Croce Date: Wed, 20 May 2020 13:16:25 +0200 Message-ID: Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables To: Russell King - ARM Linux admin Cc: Antoine Tenart , netdev , "gregory.clement@bootlin.com" , LKML , Maxime Chevallier , Nadav Haklai , Thomas Petazzoni , "miquel.raynal@bootlin.com" , Stefan Chulski , Marcin Wojtas , "David S . Miller" , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 1:11 PM Russell King - ARM Linux admin wrote: > > On Tue, May 19, 2020 at 07:05:34PM +0200, Matteo Croce wrote: > > On Tue, 19 May 2020 12:05:20 +0200 > > Matteo Croce wrote: > > > > Hi, > > > > The patch seems to work. I'm generating traffic with random MAC and IP > > addresses, to have many flows: > > > > # tcpdump -tenni eth2 > > 9a:a9:b1:3a:b1:6b > 00:51:82:11:22:02, ethertype IPv4 (0x0800), length 60: 10.0.0.4.0 > 192.168.0.4.0: UDP, length 12 > > 9e:92:fd:f8:7f:0a > 00:51:82:11:22:02, ethertype IPv4 (0x0800), length 60: 10.0.0.4.0 > 192.168.0.4.0: UDP, length 12 > > 66:b7:11:8a:c2:1f > 00:51:82:11:22:02, ethertype IPv4 (0x0800), length 60: 10.0.0.1.0 > 192.168.0.1.0: UDP, length 12 > > 7a:ba:58:bd:9a:62 > 00:51:82:11:22:02, ethertype IPv4 (0x0800), length 60: 10.0.0.1.0 > 192.168.0.1.0: UDP, length 12 > > 7e:78:a9:97:70:3a > 00:51:82:11:22:02, ethertype IPv4 (0x0800), length 60: 10.0.0.2.0 > 192.168.0.2.0: UDP, length 12 > > b2:81:91:34:ce:42 > 00:51:82:11:22:02, ethertype IPv4 (0x0800), length 60: 10.0.0.2.0 > 192.168.0.2.0: UDP, length 12 > > 2a:05:52:d0:d9:3f > 00:51:82:11:22:02, ethertype IPv4 (0x0800), length 60: 10.0.0.3.0 > 192.168.0.3.0: UDP, length 12 > > ee:ee:47:35:fa:81 > 00:51:82:11:22:02, ethertype IPv4 (0x0800), length 60: 10.0.0.3.0 > 192.168.0.3.0: UDP, length 12 > > > > This is the default rate, with rxhash off: > > > > # utraf eth2 > > tx: 0 bps 0 pps rx: 397.4 Mbps 827.9 Kpps > > tx: 0 bps 0 pps rx: 396.3 Mbps 825.7 Kpps > > tx: 0 bps 0 pps rx: 396.6 Mbps 826.3 Kpps > > tx: 0 bps 0 pps rx: 396.5 Mbps 826.1 Kpps > > > > PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND > > 9 root 20 0 0 0 0 R 99.7 0.0 7:02.58 ksoftirqd/0 > > 15 root 20 0 0 0 0 S 0.0 0.0 0:00.00 ksoftirqd/1 > > 20 root 20 0 0 0 0 S 0.0 0.0 2:01.48 ksoftirqd/2 > > 25 root 20 0 0 0 0 S 0.0 0.0 0:32.86 ksoftirqd/3 > > > > and this with rx hashing enabled: > > > > # ethtool -K eth2 rxhash on > > # utraf eth2 > > tx: 0 bps 0 pps rx: 456.4 Mbps 950.8 Kpps > > tx: 0 bps 0 pps rx: 458.4 Mbps 955.0 Kpps > > tx: 0 bps 0 pps rx: 457.6 Mbps 953.3 Kpps > > tx: 0 bps 0 pps rx: 462.2 Mbps 962.9 Kpps > > > > PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND > > 20 root 20 0 0 0 0 R 0.7 0.0 2:02.34 ksoftirqd/2 > > 25 root 20 0 0 0 0 S 0.3 0.0 0:33.25 ksoftirqd/3 > > 9 root 20 0 0 0 0 S 0.0 0.0 7:52.57 ksoftirqd/0 > > 15 root 20 0 0 0 0 S 0.0 0.0 0:00.00 ksoftirqd/1 > > > > > > The throughput doesn't increase so much, maybe we hit an HW limit of > > the gigabit port. The interesting thing is how the global CPU usage > > drops from 25% to 1%. > > I can't explain this, it could be due to the reduced contention? > > Hi Matteo, > > Can I take that as a Tested-by ? > > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up > Tested-by: Matteo Croce probably also: Reported-by: Matteo Croce Thanks, -- Matteo Croce per aspera ad upstream