From: Steve French <smfrench@gmail.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org
Subject: Re: [PATCH -next] cifs: fix printk format warnings
Date: Tue, 31 Jan 2012 07:43:37 -0600 [thread overview]
Message-ID: <CAH2r5mu2VXWkP49RzPuedN9hY6G-WcbyYB3WMJSf2NkRe2VO7Q@mail.gmail.com> (raw)
In-Reply-To: <20120131054231.66669e41@tlielax.poochiereds.net>
Merged to cifs-2.6.git
On Tue, Jan 31, 2012 at 4:42 AM, Jeff Layton <jlayton@redhat.com> wrote:
> On Mon, 30 Jan 2012 19:50:01 -0800
> Randy Dunlap <rdunlap@xenotime.net> wrote:
>
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> Fix printk format warnings for ssize_t variables:
>>
>> fs/cifs/connect.c:2145:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2152:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2160:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>> fs/cifs/connect.c:2170:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: Steve French <sfrench@samba.org>
>> Cc: linux-cifs@vger.kernel.org
>> ---
>> fs/cifs/connect.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> --- linux-next-20120130.orig/fs/cifs/connect.c
>> +++ linux-next-20120130/fs/cifs/connect.c
>> @@ -2142,14 +2142,14 @@ cifs_set_cifscreds(struct smb_vol *vol,
>>
>> len = delim - payload;
>> if (len > MAX_USERNAME_SIZE || len <= 0) {
>> - cFYI(1, "Bad value from username search (len=%ld)", len);
>> + cFYI(1, "Bad value from username search (len=%zd)", len);
>> rc = -EINVAL;
>> goto out_key_put;
>> }
>>
>> vol->username = kstrndup(payload, len, GFP_KERNEL);
>> if (!vol->username) {
>> - cFYI(1, "Unable to allocate %ld bytes for username", len);
>> + cFYI(1, "Unable to allocate %zd bytes for username", len);
>> rc = -ENOMEM;
>> goto out_key_put;
>> }
>> @@ -2157,7 +2157,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
>>
>> len = key->datalen - (len + 1);
>> if (len > MAX_PASSWORD_SIZE || len <= 0) {
>> - cFYI(1, "Bad len for password search (len=%ld)", len);
>> + cFYI(1, "Bad len for password search (len=%zd)", len);
>> rc = -EINVAL;
>> kfree(vol->username);
>> vol->username = NULL;
>> @@ -2167,7 +2167,7 @@ cifs_set_cifscreds(struct smb_vol *vol,
>> ++delim;
>> vol->password = kstrndup(delim, len, GFP_KERNEL);
>> if (!vol->password) {
>> - cFYI(1, "Unable to allocate %ld bytes for password", len);
>> + cFYI(1, "Unable to allocate %zd bytes for password", len);
>> rc = -ENOMEM;
>> kfree(vol->username);
>> vol->username = NULL;
>
> Looks correct.
>
> Acked-by: Jeff Layton <jlayton@redhat.com>
--
Thanks,
Steve
prev parent reply other threads:[~2012-01-31 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 3:41 linux-next: Tree for Jan 30 Stephen Rothwell
2012-01-30 19:40 ` [PATCH -next] cpufreq: fix gx-suspmod.c build Randy Dunlap
2012-01-30 18:55 ` Dave Jones
2012-01-30 19:42 ` [PATCH -next] sound: fix include/sound/core.h warning Randy Dunlap
2012-01-30 20:15 ` Takashi Iwai
2012-01-30 19:43 ` [PATCH -next] vgaarb.h: fix build warnings Randy Dunlap
2012-03-13 21:25 ` Randy Dunlap
2012-01-31 3:08 ` [PATCH -next] mtd: fix nand/docg4.c printk format warnings Randy Dunlap
2012-01-31 3:09 ` [PATCH -next] ext4: fix balloc.c printk format warning Randy Dunlap
2012-01-31 3:49 ` [PATCH -next] ramoops: fix printk format warnings Randy Dunlap
2012-01-31 3:50 ` [PATCH -next] cifs: " Randy Dunlap
2012-01-31 10:42 ` Jeff Layton
2012-01-31 13:43 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mu2VXWkP49RzPuedN9hY6G-WcbyYB3WMJSf2NkRe2VO7Q@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).