From: Adam Ford <aford173@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Adam Ford-BE <aford@beaconembedded.com>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 06/18] arm64: dts: renesas: beacon: Configure Audio CODEC clocks
Date: Thu, 17 Dec 2020 11:58:11 -0600 [thread overview]
Message-ID: <CAHCN7xKdVv==YLtSa3n2hQk2T+f+FkLqKDNTYkP_3ynnY+xRCg@mail.gmail.com> (raw)
In-Reply-To: <CAHCN7xJf2T3uFLDtJxvjFYzCksWq02+CUY51_WmnU44YDJKy9Q@mail.gmail.com>
On Thu, Dec 17, 2020 at 7:33 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Thu, Dec 17, 2020 at 5:12 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Adam,
> >
> > CC alsa-devel
> >
> > On Sun, Dec 13, 2020 at 7:38 PM Adam Ford <aford173@gmail.com> wrote:
> > > With the newly added configurable clock options, the audio CODEC can
> > > configure the mclk automatically. Add the reference to the versaclock.
> > > Since the devices on I2C5 can communicate at 400KHz, let's also increase
> > > that too
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> > > @@ -424,13 +424,15 @@ &i2c0 {
> > >
> > > &i2c5 {
> > > status = "okay";
> > > - clock-frequency = <100000>;
> > > + clock-frequency = <400000>;
> > > pinctrl-0 = <&i2c5_pins>;
> > > pinctrl-names = "default";
> > >
> > > codec: wm8962@1a {
> > > compatible = "wlf,wm8962";
> > > reg = <0x1a>;
> > > + clocks = <&versaclock6_bb 3>;
> > > + clock-names = "mclk";
> >
> > While the driver does get the (nameless) clock, the DT bindings lack any
> > mention of a clocks property. It would be good to update the bindings.
>
> Agreed. I'll push an update to add the clocks property.
>
I pushed a change to add the optional clock information to the
bindings txt file [1].
> >
> > Note that arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi and
> > arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi (both by your
> > hand) use "xclk" instead of "mclk"?
>
> On the schematics for the two imx boards, it's labeled as xclk, so it
> was named as such. For this board, the schematic names it mclk. The
> driver doesn't care about the clock-names property, so I'll just
> remove them.
I pushed patches to remove these nodes from the other boards [2].
I'll remove them if V2 of the patch series for the Renesas board.
adam
[1] - https://patchwork.kernel.org/project/alsa-devel/patch/20201217162740.1452000-1-aford173@gmail.com/
[2] - https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=403739
>
> adam
> >
> > > DCVDD-supply = <®_audio>;
> > > DBVDD-supply = <®_audio>;
> > > AVDD-supply = <®_audio>;
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> > -- Linus Torvalds
next prev parent reply other threads:[~2020-12-17 17:59 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 18:37 [PATCH 00/18] arm64: dts: renesas: Cleanup Beacon Kit and support more SoC's Adam Ford
2020-12-13 18:37 ` [PATCH 01/18] arm64: dts: renesas: beacon kit: Configure programmable clocks Adam Ford
2020-12-16 14:55 ` Geert Uytterhoeven
2020-12-16 17:03 ` Adam Ford
2020-12-17 8:16 ` Geert Uytterhoeven
2020-12-17 11:52 ` Adam Ford
2020-12-18 13:16 ` Geert Uytterhoeven
2020-12-22 1:39 ` Adam Ford
2020-12-22 8:03 ` Geert Uytterhoeven
2020-12-24 13:52 ` Adam Ford
2020-12-28 12:33 ` Geert Uytterhoeven
2020-12-28 14:38 ` Adam Ford
2020-12-28 14:52 ` Geert Uytterhoeven
2021-05-05 12:07 ` Adam Ford
2020-12-13 18:37 ` [PATCH 02/18] arm64: dts: renesas: beacon kit: Fix choppy Bluetooth Audio Adam Ford
2020-12-17 10:41 ` Geert Uytterhoeven
2020-12-17 12:16 ` Adam Ford
2020-12-18 13:00 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 03/18] arm64: dts: renesas: beacon kit: Remove unnecessary nodes Adam Ford
2020-12-17 10:43 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 04/18] arm64: dts: renesas: beacon kit: Fix Audio Clock sources Adam Ford
2020-12-17 10:54 ` Geert Uytterhoeven
2020-12-17 12:01 ` Adam Ford
2020-12-18 13:05 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 05/18] arm64: dts: renesas: beacon: Fix audio-1.8V pin enable Adam Ford
2020-12-17 10:57 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 06/18] arm64: dts: renesas: beacon: Configure Audio CODEC clocks Adam Ford
2020-12-17 11:11 ` Geert Uytterhoeven
2020-12-17 13:33 ` Adam Ford
2020-12-17 17:58 ` Adam Ford [this message]
2020-12-18 12:57 ` Geert Uytterhoeven
2020-12-18 14:23 ` Adam Ford
2020-12-13 18:37 ` [PATCH 07/18] arm64: dts: renesas: beacon: Fix LVDS PWM Backlight Adam Ford
2020-12-17 11:14 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 08/18] arm64: dts: renesas: beacon: Enable SCIF4 Adam Ford
2020-12-17 11:20 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 09/18] arm64: dts: renesas: beacon: Fix RGB Display PWM Backlight Adam Ford
2020-12-17 11:24 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 10/18] arm64: dts: renesas: Don't make vccq_sdhi0 always on Adam Ford
2020-12-17 11:24 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 11/18] arm64: dts: renesas: beacon: Remove redundant audio code Adam Ford
2020-12-13 18:37 ` [PATCH 12/18] arm64: dts: renesas: beacon: Better describe keys Adam Ford
2020-12-17 11:31 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 13/18] arm64: dts: renesas: beacon: Enable SPI Adam Ford
2020-12-17 11:34 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 14/18] arm64: dts: renesas: beacon: Correct I2C bus speeds Adam Ford
2020-12-17 11:38 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 15/18] arm64: dts: renesas: beacon-rzg2m-kit: Rearange SoC unique functions Adam Ford
2020-12-17 11:41 ` Geert Uytterhoeven
2020-12-17 11:47 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 16/18] dt-bindings: arm: renesas: Add Beacon RZ/G2N and RZ/G2H boards Adam Ford
2020-12-15 17:03 ` Rob Herring
2020-12-17 11:42 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 17/18] arm64: dts: renesas: Introduce r8a774b1-beacon-rzg2n-kit Adam Ford
2020-12-17 11:49 ` Geert Uytterhoeven
2020-12-22 13:58 ` Adam Ford
2020-12-22 14:26 ` Biju Das
2020-12-13 18:37 ` [PATCH 18/18] arm64: dts: renesas: Introduce r8a774e1-beacon-rzg2h-kit Adam Ford
2020-12-17 11:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHCN7xKdVv==YLtSa3n2hQk2T+f+FkLqKDNTYkP_3ynnY+xRCg@mail.gmail.com' \
--to=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).