linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@verdurent.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 6/9] thermal: Move get_thermal_instance to the internal header
Date: Sat, 4 Apr 2020 13:00:00 +0530	[thread overview]
Message-ID: <CAHLCerMXEt1hQtzBLRxsEvWBq75AHdaAOc1b6XgWOTVSPxmDJQ@mail.gmail.com> (raw)
In-Reply-To: <20200402142747.8307-6-daniel.lezcano@linaro.org>

On Thu, Apr 2, 2020 at 7:58 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> The function is not used any place other than the thermal
> directory. It does not make sense to export its definition in the
> global header as there is no use of it.
>
> Move the definition to the internal header and allow better
> self-encapsulation.
>
> Take the opportunity to add the parameter names to make checkpatch
> happy and remove the pointless stubs.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>

> ---
>  drivers/thermal/thermal_core.h | 5 +++++
>  include/linux/thermal.h        | 6 ------
>  2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
> index 5fb2bd9c7034..c95689586e19 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -74,6 +74,11 @@ struct thermal_trip {
>
>  int get_tz_trend(struct thermal_zone_device *tz, int trip);
>
> +struct thermal_instance *
> +get_thermal_instance(struct thermal_zone_device *tz,
> +                    struct thermal_cooling_device *cdev,
> +                    int trip);
> +
>  /*
>   * This structure is used to describe the behavior of
>   * a certain cooling device on a certain trip point
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 8006ba5de855..47e745c5dfca 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -414,8 +414,6 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp);
>  int thermal_zone_get_slope(struct thermal_zone_device *tz);
>  int thermal_zone_get_offset(struct thermal_zone_device *tz);
>
> -struct thermal_instance *get_thermal_instance(struct thermal_zone_device *,
> -               struct thermal_cooling_device *, int);
>  void thermal_cdev_update(struct thermal_cooling_device *);
>  void thermal_notify_framework(struct thermal_zone_device *, int);
>  #else
> @@ -473,10 +471,6 @@ static inline int thermal_zone_get_offset(
>                 struct thermal_zone_device *tz)
>  { return -ENODEV; }
>
> -static inline struct thermal_instance *
> -get_thermal_instance(struct thermal_zone_device *tz,
> -       struct thermal_cooling_device *cdev, int trip)
> -{ return ERR_PTR(-ENODEV); }
>  static inline void thermal_cdev_update(struct thermal_cooling_device *cdev)
>  { }
>  static inline void thermal_notify_framework(struct thermal_zone_device *tz,
> --
> 2.17.1
>

  reply	other threads:[~2020-04-04  7:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 14:27 [PATCH V2 1/9] thermal: Move default governor config option to the internal header Daniel Lezcano
2020-04-02 14:27 ` [PATCH V2 2/9] thermal: Move struct thermal_attr to the private header Daniel Lezcano
2020-04-04  7:30   ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 3/9] thermal: Move internal IPA functions Daniel Lezcano
2020-04-04  7:30   ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 4/9] thermal: Move trip point structure definition to private header Daniel Lezcano
2020-04-04  7:30   ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 5/9] thermal: Move get_tz_trend to the internal header Daniel Lezcano
2020-04-04  7:30   ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 6/9] thermal: Move get_thermal_instance " Daniel Lezcano
2020-04-04  7:30   ` Amit Kucheria [this message]
2020-04-02 14:27 ` [PATCH V2 7/9] thermal: Change IS_ENABLED to IFDEF in the header file Daniel Lezcano
2020-04-04  7:30   ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 8/9] thermal: Remove stubs for thermal_zone_[un]bind_cooling_device Daniel Lezcano
2020-04-04  7:30   ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 9/9] thermal: Remove thermal_zone_device_update() stub Daniel Lezcano
2020-04-04  7:30   ` Amit Kucheria
2020-04-04  7:30 ` [PATCH V2 1/9] thermal: Move default governor config option to the internal header Amit Kucheria
2020-04-12  8:35 ` Zhang Rui
2020-04-12  8:39   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHLCerMXEt1hQtzBLRxsEvWBq75AHdaAOc1b6XgWOTVSPxmDJQ@mail.gmail.com \
    --to=amit.kucheria@verdurent.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).